-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields read-only view should show real resources blocked #5355
Labels
feature/shields
The overall Shields feature in Brave.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jul 23, 2019
- at the moment it shows a static/hard-coded version fix brave/brave-browser#5355
6 tasks
@cezaraugusto once this is closed, please add either |
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jul 31, 2019
- at the moment it shows a static/hard-coded version fix brave/brave-browser#5355
This was referenced Aug 22, 2019
Verification passed on
Verified passed with
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/shields
The overall Shields feature in Brave.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
At the moment it shows a hard-coded version of resources.
Test Plan
What happens
Stats are hard-coded at 2. A hard-coded resource blocked is shown.
What should happen
Should show a list of resources blocked on the current site
The text was updated successfully, but these errors were encountered: