Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields read-only view should show real resources blocked #5355

Closed
cezaraugusto opened this issue Jul 23, 2019 · 2 comments · Fixed by brave/brave-core#2987
Closed

Shields read-only view should show real resources blocked #5355

cezaraugusto opened this issue Jul 23, 2019 · 2 comments · Fixed by brave/brave-core#2987

Comments

@cezaraugusto
Copy link
Contributor

At the moment it shows a hard-coded version of resources.

Test Plan

  1. Fresh profile
  2. Open Shields
  3. Click "Learn more"
  4. Click any resource blocked

What happens

Stats are hard-coded at 2. A hard-coded resource blocked is shown.

What should happen

Should show a list of resources blocked on the current site

@cezaraugusto cezaraugusto added the feature/shields The overall Shields feature in Brave. label Jul 23, 2019
@cezaraugusto cezaraugusto self-assigned this Jul 23, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 23, 2019
-
at the moment it shows a static/hard-coded version
fix brave/brave-browser#5355
@kjozwiak
Copy link
Member

@cezaraugusto once this is closed, please add either QA/Yes or QA/No as needed 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 27, 2019

Verification passed on

Brave 0.69.113 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the test plan from allow shields read-only view to show actual resources blocked brave-core#2987
  • Verified that the blocked resources count is not hardcoded
  • Verified the count of blocked resources is equal to the number of scripts blocked in panel ( copied blocked resources from the panel and counted manually)
  • Verified that resources or scripts blocked are referred to the current website

image

Verified passed with

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment