Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim is not working #5366

Closed
NejcZdovc opened this issue Jul 24, 2019 · 1 comment · Fixed by brave/brave-core#2996
Closed

Claim is not working #5366

NejcZdovc opened this issue Jul 24, 2019 · 1 comment · Fixed by brave/brave-core#2996

Comments

@NejcZdovc
Copy link
Contributor

Description

Claim process for anon user funds doesn't work.

Steps to Reproduce

  1. enable rewards
  2. recover old wallet with some user funds (no grants)
  3. connect uphold KYC'd wallet

Actual result:

nothing happens

Expected result:

user funds should be transfer into connected uphold wallet

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Aug 23, 2019

Verified passed with

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

(all testing completed on Staging env)

  • Verified test plan from Fixes claim amount brave-core#2996
  • Verified BAT from anon wallet moved to my verified, KYC'd Brave Browser card on Uphold. Verified if I started a clean profile and restored the previous anon wallet, it showed a 0 balance on restore as the BAT had been moved. Confirmed on balance-staging and ledger-staging servers.
  • Verified BAT from anon wallet was not to my verified, un-KYC'd Brave Browser card on Uphold. Verified if I started a clean profile and restored the previous anon wallet, it showed a non-0 balance on restore as the BAT had not been moved. Confirmed on balance-staging and ledger-staging servers.
  • Note, need to handle scenario of when user restores wallet after connecting rewards to Uphold #5344 is logged for if you do the steps out of order from test plan (verify wallet and then restore anon wallet with balance)

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

image

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified BAT from anon wallet moved to my verified, KYC'd Brave Browser card on Uphold. Verified if I started a clean profile and restored the previous anon wallet, it showed a 0 balance on restore as the BAT had been moved. Confirmed on balance-staging and ledger-staging servers.
  • Verified BAT from anon wallet was not to moved my verified, un-KYC'd Brave Browser card on Uphold. Verified if I started a clean profile and restored the previous anon wallet, it showed a non-0 balance on restore as the BAT had not been moved. Confirmed on balance-staging and ledger-staging servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment