Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel is broken for Twitch - unable to tip Twitch publishers #5549

Closed
LaurenWags opened this issue Aug 6, 2019 · 5 comments · Fixed by brave/brave-core#3295
Closed

Panel is broken for Twitch - unable to tip Twitch publishers #5549

LaurenWags opened this issue Aug 6, 2019 · 5 comments · Fixed by brave/brave-core#3295

Comments

@LaurenWags
Copy link
Member

Description

This has happened before, see #4680

When visiting a twitch channel and clicking on the BAT logo, the panel shows twitch.com, not the publisher information, so you are unable to tip twitch publishers.

Steps to Reproduce

  1. Clean profile with 0.67.x release or 0.68.x beta
  2. Enable Rewards
  3. Visit twitch channel page (ex. twitch.tv/bobross)
  4. Click on BAT logo after page is fully loaded --> panel shows twitch.tv, not BobRoss on Twitch. Try a few more times, same result.
  5. Watch a video. During video click on BAT logo. --> panel shows twitch.tv, not BobRoss on Twitch. Try a few more times, same result.

Actual result:

Panel shows twitch.com, not something like BobRoss on Twitch
twitchpanel

Expected result:

Panel should show publisher info (including favicon IF publisher is verified)

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.123 Chromium: 76.0.3809.87 (Official Build) (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
Brave 0.69.99 Chromium: 76.0.3809.87 (Official Build) dev (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure but probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @NejcZdovc @alexwykoff @mandar-brave @rebron @brave/legacy_qa

@btlechowski
Copy link

btlechowski commented Aug 6, 2019

Reproduced on Windows

Brave 0.67.123 Chromium: 76.0.3809.87 (Official Build) (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 7 Service Pack 1 (Build 7601.24494)

https://www.twitch.tv/toyzttv

image

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 8, 2019

@mandar-brave mandar-brave added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Aug 14, 2019
@mandar-brave
Copy link

Moving up the stack; below the 0.69 needs but should fix right after.
@alexwykoff

@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 4, 2019

Verified passed with

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Panel for Verified Twitch Publisher:
Screen Shot 2019-09-04 at 5 36 35 PM

Panel for Connected, not verified Twitch Publisher:
Screen Shot 2019-09-04 at 5 42 24 PM

Panel for unverified Twitch Publisher:
Screen Shot 2019-09-04 at 5 35 17 PM

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Panel for Verified Twitch Publisher:
image

Panel for Connected, not verified Twitch Publisher:
image

Panel for unverified Twitch Publisher:
image

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Panel for Verified Twitch Publisher:
image

Panel for Connected, not verified Twitch Publisher:
image

Panel for unverified Twitch Publisher:
image

@rebron rebron changed the title panel is broken for twitch - unable to tip twitch publishers Panel is broken for twitch - unable to tip twitch publishers Oct 2, 2019
@rebron rebron changed the title Panel is broken for twitch - unable to tip twitch publishers Panel is broken for Twitch - unable to tip Twitch publishers Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants