Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self tipping should not take Brave 5% fee #5594

Closed
mandar-brave opened this issue Aug 8, 2019 · 1 comment · Fixed by brave/brave-core#3202
Closed

Self tipping should not take Brave 5% fee #5594

mandar-brave opened this issue Aug 8, 2019 · 1 comment · Fixed by brave/brave-core#3202

Comments

@mandar-brave
Copy link

For user wallets, self tipping is not permitted!
However, while self tipping fails, Brave ledger collects a 5% fee. This fee should not be deducted.

@NejcZdovc

@LaurenWags
Copy link
Member

LaurenWags commented Aug 27, 2019

Verified passed with

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Connected a verified, KYC'd staging publisher account to staging Rewards in browser. Attempted to self-tip my own site and was unsuccessful. Expected error received on panel and my wallet balance was unchanged. Additionally, the 5% staging card balance was not changed.
    Screen Shot 2019-08-27 at 4 36 09 PM

Screen Shot 2019-08-27 at 4 35 36 PM

  • I then proceeded to verify the test plan from Fixes 5% fee when contribution fails brave-core#3202 where I tipped a different, verified site (KYC'd). Tip was deducted from my balance accordingly. Additionally, the 5% did go to the expected 5% staging card in Uphold. Also I was able to view the transactions in Uphold.
    Screen Shot 2019-08-27 at 4 48 21 PM
    Screen Shot 2019-08-27 at 4 49 27 PM

Screen Shot 2019-08-27 at 4 49 56 PM

Transaction on KYC'd staging acct:
Screen Shot 2019-08-27 at 4 49 08 PM

Transaction on acct with 5% staging card: (note, issue of name displaying will be resolved by #5808)

Screen Shot 2019-08-27 at 4 55 15 PM

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Connected a verified, KYC'd staging publisher account to staging Rewards in browser. Attempted to self-tip my own site (https://www.twitch.tv/gsarvadnya) and was unsuccessful. Expected error received on panel and my wallet balance was unchanged. Additionally, the 5% staging card balance was not changed.

image

image

  • then proceeded to verify the test plan from Fixes 5% fee when contribution fails brave-core#3202 where I tipped a different, verified site (KYC'd). Tip was deducted from my balance accordingly. Additionally, the 5% did go to the expected 5% staging card in Uphold. Also I was able to view the transactions in Uphold.

image

image

image

Transaction on KYC'd staging acct:

image

  • Verified tipping 5BAT to a verified KYC'd twitter pub and verified that the tip was deducted from my balance accordingly. Additionally, 25% did go to the expected 5% staging card in Uphold. Also I was able to view the transactions in Uphold.

image

Transaction on KYC'd staging acct:
image

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS
  • Connected a verified, KYC'd staging publisher account to staging Rewards in browser. Attempted to self-tip my own site and was unsuccessful. Expected error received on panel and my wallet balance was unchanged. Additionally, the 5% staging card balance was not changed.
    image

Transaction on KYC'd staging acct:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants