Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebTorrent extension is broken #5604

Closed
feross opened this issue Aug 9, 2019 · 3 comments
Closed

WebTorrent extension is broken #5604

feross opened this issue Aug 9, 2019 · 3 comments
Assignees
@yrliou
Labels
bug feature/webtorrent Label for webtorrent related issues priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@feross
Copy link

feross commented Aug 9, 2019

Description

The last update we did to bittorrent-tracker broke the WebTorrent extension. I confirmed it's broken in Nightly.

The issue is that the URL constructor is buggy Chromium. https://bugs.chromium.org/p/chromium/issues/detail?id=734880

We switched to URL from require('url') in bittorrent-tracker@9.13.0. Commit: webtorrent/bittorrent-tracker@93b4139

This code path was not exercised by bittorrent-tracker's tests because UDP trackers are normally only used in a Node.js environment. Brave run the code in a Chrome extension environment which we don't test.

Steps to Reproduce

  1. Open https://webtorrent.io/torrents/sintel.torrent
  2. Click start torrent

Actual result:

Torrent does not start downloading

Expected result:

Torrent should start downloading

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Nightly

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes
@feross feross added bug priority/P2 A bad problem. We might uplift this to the next planned release. feature/webtorrent Label for webtorrent related issues labels Aug 9, 2019
feross added a commit to webtorrent/bittorrent-tracker that referenced this issue Aug 9, 2019
@feross
Fix URL constructor on udp:// urls in Chrome App environment
ddee6b9 
For: brave/brave-browser#5604

`bittorrent-tracker` is broken when run in a Chrome App environment.

The issue is that the `URL` constructor is buggy Chromium. https://bugs.chromium.org/p/chromium/issues/detail?id=734880

We switched to `URL` from `require('url')` in `bittorrent-tracker@9.13.0`. Commit: 93b4139

This code path was not exercised by `bittorrent-tracker`'s tests because UDP trackers are normally only used in a Node.js environment. Braves run the code in a Chrome extension environment which we don't test.
@feross
Copy link
Author

feross commented Aug 9, 2019

Fixed in bittorrent-tracker@9.14.1.

@feross feross mentioned this issue Aug 9, 2019
Merged
32 tasks
@feross
Copy link
Author

feross commented Aug 9, 2019

Fixed by:

@feross feross closed this as completed Aug 9, 2019
@btlechowski
Copy link

btlechowski commented Aug 15, 2019 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Tested on https://webtorrent.io/free-torrents. Checked torrents and magnet links.

Verified passed on

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Verification passed on

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
bug feature/webtorrent Label for webtorrent related issues priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

No branches or pull requests
5 participants
@feross @yrliou @LaurenWags @btlechowski @GeetaSarvadnya