Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression for sliver.tv #5809

Closed
bridiver opened this issue Aug 26, 2019 · 1 comment · Fixed by brave/brave-core#3260
Closed

regression for sliver.tv #5809

bridiver opened this issue Aug 26, 2019 · 1 comment · Fixed by brave/brave-core#3260
Assignees
@bridiver
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@bridiver
Copy link
Contributor

bridiver commented Aug 26, 2019 •
edited by kjozwiak
Loading

Test Cases

Basically run through the same cases that were used under #5380 (comment) when going through sliver.tv for the first time via 0.67.x.

Original Issue

#5380 regressed with brave/brave-core#3130
@bridiver bridiver self-assigned this Aug 26, 2019
@bridiver bridiver added this to the 0.71.x - Nightly milestone Aug 26, 2019
@bridiver bridiver mentioned this issue Aug 26, 2019
Merged
32 tasks
bridiver added a commit to brave/brave-core that referenced this issue Aug 28, 2019
@bridiver
restore whitelist for silver.tv
832e124 
fix brave/brave-browser#5809
@kjozwiak
Copy link
Member

kjozwiak commented Sep 4, 2019 •
edited by btlechowski
Loading

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • ensured that I received regular coins when watching streams
  • ensured that I received TFUEL coins when watching TFUEL enabled streams
  • ensured that PENDING EARNINGS & EARNINGS THIS SESSION were being updated
  • ensured that ~10 minutes, my earned TFUEL were being submitted to the Theta Blockchain

Screen Shot 2019-09-03 at 8 24 02 PM

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • ensured that I received regular coins when watching streams
  • ensured that I received TFUEL coins when watching TFUEL enabled streams
  • ensured that PENDING EARNINGS & EARNINGS THIS SESSION were being updated
  • ensured that ~10 minutes, my earned TFUEL were being submitted to the Theta Blockchain

image

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • ensured that I received regular coins when watching streams
  • ensured that I received TFUEL coins when watching TFUEL enabled streams
  • ensured that PENDING EARNINGS & EARNINGS THIS SESSION were being updated
  • ensured that ~10 minutes, my earned TFUEL were being submitted to the Theta Blockchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

fix cookie whitelist brave/brave-core
6 participants
@bridiver @kjozwiak @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya