Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads history is limited to 99 entries #5863

Closed
tmancey opened this issue Sep 2, 2019 · 2 comments · Fixed by brave/brave-core#3906
Closed

Ads history is limited to 99 entries #5863

tmancey opened this issue Sep 2, 2019 · 2 comments · Fixed by brave/brave-core#3906
Assignees
Labels
bug feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Sep 2, 2019

Description

Ads history is limited to 99 entries

Steps to Reproduce

  1. View over 99 ads

Actual result:

Only up to 99 ads viewed during 7 days are shown in the history

Expected result:

All ads viewed during 7 days should be shown in the history

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

See kMaximumEntriesInAdsShownHistory in vendor/bat-native-ads/src/bat/ads/internal/static_values.h

@btlechowski
Copy link

This issue is blocked on #7743

@LaurenWags
Copy link
Member

Marked release-notes/exclude and QA/No per discussions with @kjozwiak and @rebron
Logged follow up issue #8046 so this can be retested with 1.4.x milestone where the blocking issue (#7743) is resolved by #6757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants