Disabled Crypto Wallets Injects Code?

[jonathansampson]

Description

Crypto Wallets is reportedly still injecting code into pages even when disabled. Other users were unable to reproduce the issue (https://twitter.com/GregJeanmart/status/1177222741239488514).

Steps to Reproduce

See #6181 (comment) below.

Actual result:

MetaMask detects injected code.

Expected result:

No code is injected when CryptoWallets is disabled.

Reproduces how often:

Always.

Brave version (brave://version info)

0.70.100 Chromium: 77.0.3865.90

Miscellaneous Information:

Reported on Twitter: https://twitter.com/bitfalls/status/1177219557712388104

[Swader]

Version 0.70.100 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Windows.

• Disable crypto wallets in settings
• Visit web3 page
• above error shows up.

Gif:

[kjozwiak]

@bbondy looks you'll need to restart the browser when disabling Brave Wallet. If Brave Wallet was enabled and you disable it but still have MM installed, you'll still get the following error as mentioned above:

Once you restart the browser and refresh https://uniswap.exchange/swap, you'll get the following:

@bbondy went through the above using 0.69.132 CR: 77.0.3865.90 which is the latest RC. However, I'm seeing the same behaviour with 0.69.131 CR: 77.0.3865.90 regarding restarting the browser so not really sure if this was really fixed. Thoughts?