Missing translations for custom text on crypto wallet

[srirambv]

Description

All custom text on crypto wallet is not translated. Found while testing #5686

Steps to Reproduce

1. Set device locale to French
2. Create a new profile and launch Crypto wallet
3. Text coming from MM is translated, custom text implemented by us isn't

Actual result:

Disclosure message

Wallet setup selection

Password warning details

Expected result:

All text should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc; @bbondy @tomlowenthal @kjozwiak

[srirambv]

+1 from @SergeyZhukovsky

[ryanml]

The welcome page issues are covered in this pull: brave/ethereum-remote-client#78

As for the disclosure message and modal - these are using translated strings but were added after last rounds of translations are ordered, so next round will fix: cc: @srirambv @bbondy

[bbondy]

FYI I'm going to closet his out with this pull request:
brave/ethereum-remote-client#85

But I'm sure there will be more translation issues. Those should be tracked in separate more specific issues please and thanks.

[NumDeP]

@ryanml I didn't know whether the bit above congratulations was a translation issue but it's typically what shows up when certain foreign languages aren't supported in brave. In addition, I don't expect to remove and re-create the wallet again so there wouldn't be a way for me to check if it was after the next couple of updates, thus didn't want it to be missed. If it is, following bondy's comment perhaps you can make a specific issue regarding it.

[srirambv]

@NumDeP can you please log a new issue for it and mention the OS details. The icon is different on different platforms.

[srirambv]

Moving the issue out of 1.0.11 release as only part of the text is translated. Follow up issue #6533 covers all untranslated text for new custom texts that needs to be verified on the next release