Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google-Translate-extention Pop-Up #6329

Closed
GraOrigin opened this issue Oct 6, 2019 · 13 comments
Closed

Google-Translate-extention Pop-Up #6329

GraOrigin opened this issue Oct 6, 2019 · 13 comments
Labels
closed/invalid needs-more-info The report requires more detail before we can decide what to do with this issue.

Comments

@GraOrigin
Copy link

Description

Since v0.69.132 I'm being plagued by a new pop-up on every english site, asking me to install google-translate-extention to translate this site. Since I've not found a option to disable it in settings and somehow "brave://config" does not exist anymore (where did this go to?) I'm wondering how to disable it.

Brave version (brave://version info)

macOS Version 0.69.132 Chromium: 77.0.3865.90 (Offizieller Build) (64-Bit)

@psisavant
Copy link

Issue also occurs on the linux build
Linux Version 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)

@TCB13
Copy link

TCB13 commented Oct 6, 2019

Same problem under Windows, does anyone test this browser? lol Who was the bright person that decided to make it popup in every f* website, really guys.

My workaround is to install the extension and then disable it.

@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2019

@GraOrigin @psisavant @TCB13 What language is set on the browser?

@srirambv srirambv added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Oct 6, 2019
@TCB13
Copy link

TCB13 commented Oct 6, 2019

@GraOrigin @psisavant @TCB13 What language is set on the browser?

Portuguese, but that's kind of irrelevant, the browser should not show a popup on every website. It should have something on the options that allows me to pick if I want translations or not.

@Numline1
Copy link

Numline1 commented Oct 6, 2019

Same thing's happening to me, 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit) mostly on websites that are non-english (my browser's set to english, so is my OS).

I've used https://aktuality.sk as an example (slovak news portal).

image

@psisavant
Copy link

psisavant commented Oct 6, 2019

@srirambv
Happens on non-English browser locale while trying to view English sites but as @TCB13 wrote that's indeed not the point. The popups are very obnoxious and there's no apparent way of disabling them. As such I didn't install the extension in fear of not being able to disable its effects later.

@yrliou
Copy link
Member

yrliou commented Oct 6, 2019

@GraOrigin @psisavant @TCB13 @Numline1
The option to disable the popups is in the Language drop down at brave://settings/languages.
Please see below for screenshot of the Offer to translate pages that aren't in a language you read option, thanks.
google_translate
And yes, the extension can be disabled through brave://extensions if you do decide to install it.

@dschwank
Copy link

dschwank commented Oct 6, 2019

Oh boy - that setting is really hard to find. Thanks @yrliou - this worked for me.

@psisavant
Copy link

@yrliou
Seems like that dropdown was well-hidden for me due to non-dark GUI chosen.
Everything's been working fine after adjusting these options.
Nevertheless, making the popup less aggressive or otherwise capable of taking the user to the translation options could make it more accessible.

@vincentdeity
Copy link

I suggest the popup adds a button "Never ask again" that will toggle the setting on brave://settings/languages

@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

@vincentdeity yup agreed, brought this up in one of our Slack channels yesterday re: adding a Never ask again checkbox. Similar to what we have with Widevine. Created #6340. We'll get this fixed ASAP 👍

@andreabenetton
Copy link

brave://settings/languages

I'm on Linux Version 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit), Italian language set and the option isn't there.
image

@yrliou
Copy link
Member

yrliou commented Oct 11, 2019

Screen Shot 2019-10-11 at 12 11 20 PM

With today's release (Version 0.69.135), the prompt contains a button `Don't ask me again` for users to disable the prompt. (#6340) The setting could still be changed through `Language` dropdown in `brave://settings/languages` after. I'm going to close this issue since it's now addressed, thanks.

@yrliou yrliou closed this as completed Oct 11, 2019
@yrliou yrliou added this to the Dupe / Invalid / Not actionable milestone Oct 11, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid needs-more-info The report requires more detail before we can decide what to do with this issue.
Projects
None yet
Development

No branches or pull requests