-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "Never Ask Again" under Google Translate popup #6340
Labels
design
A design change, especially one which needs input from the design team
feature/translate
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
rebron
added
the
design
A design change, especially one which needs input from the design team
label
Oct 7, 2019
@bradleyrichter @karenkliu Do we even need a mock? I think we can simply go with the: |
32 tasks
Test plan specified in brave/brave-core#3617 (comment). |
bsclifton
modified the milestones:
0.72.x - Nightly,
0.71.x - Dev,
0.69.x - next release
Oct 8, 2019
This was referenced Oct 10, 2019
Verification passed on
Verified passed with
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/translate
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
When we released the Google Translate popup feature in
0.69.x
via #5561, it made using Brave more inconvenient for none-english peaking users as they constantly get the popup when visiting English websites. Some examples of user concerns: #6326, #6329, #208 (comment), #208 (comment).We should add a
Never ask again
or aDon't ask again
checkbox under the prompt that would control theOffer to translate pages that aren't in a language you read
setting viabrave://settings/languages
.Steps to Reproduce
0.69.132 Chromium: 77.0.3865.90
Actual result:
Expected result:
Should be similar to what we implemented with Widevine. Example:
Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Version/Channel Information:
Yes
Yes
Yes
Yes
Other Additional Information:
N/A
N/A
N/A
Miscellaneous Information:
CCing @rebron @bsclifton @bbondy @davidtemkin @yrliou @brave/legacy_qa
The text was updated successfully, but these errors were encountered: