Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically generated PDF does not load properly #884

Closed
bsclifton opened this issue Aug 30, 2018 · 13 comments · Fixed by brave/brave-core#2342
Closed

Dynamically generated PDF does not load properly #884

bsclifton opened this issue Aug 30, 2018 · 13 comments · Fixed by brave/brave-core#2342
Assignees
@simonhong
Labels
extension/PDFJS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.68.x - Release

Comments

@bsclifton
Copy link
Member

bsclifton commented Aug 30, 2018 •
edited
Loading

Test plan

See brave/brave-core#2342

Description

Carried over from brave/browser-laptop#8687

Steps to reproduce

  1. Try to load http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.105.6357&rep=rep1&type=pdf
  2. Notice there is an error
  3. Try same URL in Chrome and verify it works as expected
@bsclifton bsclifton added this to the Backlog milestone Aug 30, 2018
@bsclifton bsclifton mentioned this issue Aug 30, 2018
Closed
@btlechowski
Copy link

+1 from community. The user uses this feature for work.
https://community.brave.com/t/beta-crashes-accessing-sigma-aldrich-site/33524

The page contains dynamically generated pdf, which is placed in an iframe.

link to the page

image

@jasonrsadler
Copy link

Viewing paystubs on namely also produces invalid pdf structure error.

Viewing on browser-laptop works properly
screen shot 2018-10-07 at 1 06 56 pm

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 13, 2018
@cndouglas
Copy link
Contributor

+1 from brave/browser-laptop#15326.

@cndouglas cndouglas mentioned this issue Dec 5, 2018
Closed
3 tasks
@SilverPuppy
Copy link

SilverPuppy commented Dec 10, 2018 •
edited
Loading

I also use this for work. This hasn't worked correctly for years. I discovered it when Google Calendar, which my store uses, experienced this issue. I first had the problem in 2016. This was under the old brave-laptop codebase. How is the current codebase, a hacked up Chrome, still having this issue?

I'm being forced to keep FireFaux open to use GC, and I don't like that. EDIT: for the time being I've reinstalled 0.26. Be avenged, Mr. Eich! :)

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@SilverPuppy SilverPuppy mentioned this issue Mar 4, 2019
Closed
@SilverPuppy
Copy link

This still is not working, so I'm assuming that for the time being this issue is being overlooked. My current workaround is simply to download instead of using PDF.js but this is a clunky solution. Is this going to be addressed any time soon? As shown by the duplicate bug I just marked, this is affecting more people than just me.

@kjozwiak kjozwiak added the QA/Yes label Mar 7, 2019
@megaroeny
Copy link

Not working for me either on Version 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 27, 2019 •
edited
Loading

1+https://community.brave.com/t/the-usual-pdf-viewer-doesnt-work-on-some-pdf-links/36781/7

@bsclifton bsclifton mentioned this issue Mar 28, 2019
Closed
12 tasks
@GeetaSarvadnya
Copy link

1+ https://community.brave.com/t/cant-download-pdf-unexpected-response-from-server/51666/2

@bsclifton bsclifton mentioned this issue Apr 25, 2019
Merged
28 tasks
@Brave-Matt
Copy link

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/bm8xb3/issue_cant_scroll_using_mouse_in_pdfs/

@bsclifton bsclifton added this to the 0.67.x - Nightly milestone May 24, 2019
bsclifton added a commit to brave/brave-core that referenced this issue May 24, 2019
@bsclifton
WIP - removal of pdf.js
feadd12 
Fixes brave/brave-browser#3846
Fixes brave/brave-browser#3694
Fixes brave/brave-browser#884
Fixes brave/brave-browser#3119
jumde pushed a commit to brave/brave-core that referenced this issue May 30, 2019
@bsclifton @jumde
WIP - removal of pdf.js
2681798 
Fixes brave/brave-browser#3846
Fixes brave/brave-browser#3694
Fixes brave/brave-browser#884
Fixes brave/brave-browser#3119
@bsclifton bsclifton removed this from the 0.67.x - Dev milestone May 31, 2019
This was referenced Oct 11, 2019
Closed
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Oct 11, 2019
Closed
85 tasks
@btlechowski btlechowski mentioned this issue Oct 11, 2019
Closed
85 tasks
@ivigamberdiev ivigamberdiev mentioned this issue Oct 13, 2019
Closed
This was referenced Oct 14, 2019
Closed
Closed
@btlechowski btlechowski mentioned this issue Oct 15, 2019
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Oct 16, 2019
Closed
This was referenced Oct 16, 2019
Closed
Closed
This was referenced Oct 17, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost mentioned this issue Oct 20, 2019
Closed
@mhosks mhosks mentioned this issue Oct 21, 2019
Closed
@Doomfang3 Doomfang3 mentioned this issue Oct 23, 2019
Closed
@aborigines aborigines mentioned this issue Oct 24, 2019
Closed
@afxgroup afxgroup mentioned this issue Oct 28, 2019
Closed
@kushthedude kushthedude mentioned this issue Nov 2, 2019
Closed
@stephendonner stephendonner mentioned this issue Mar 5, 2021
Closed
@snyk-bot snyk-bot mentioned this issue Jan 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
extension/PDFJS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Use pdfium brave/brave-core