Remove PDF.js in favor of using PDFium

[bsclifton]

Test plan

See brave/brave-core#2342

Justification

Some of the reasons for removing include:

• high memory overhead
• large number of reported PDF issues

Tasks

• remove option to disable PDF.js from settings
• remove PDF.js manifest override
• remove existing install of PDF.js (if present)
• update build / GN flags to ensure PDFium is included/enabled
• test existing PDF issues and close ones which are fixed with PDFium
• security review

Round-up of PDF.js issues this will fix:

• Printing from Google web apps (Docs, Sheets, etc) saves to PDF instead of opening print dialog Printing from Google web apps (Docs, Sheets, etc) saves to PDF instead of opening print dialog #3694
• Dynamically generated PDF does not load properly Dynamically generated PDF does not load properly #884
• Cannot open pdf file in new window, No problems with Chrome. PDF inside of a popup window does not load (works fine in Chrome) #3119

Issues that we'll have to ask users for help re-testing:

• PDF embed on a site that require login doesn't open. PDF embed on a site that require login doesn't open. #2092
• Issue loading coldfusion generated PDF's Issue loading coldfusion generated PDF's #4216
• Weird "dirt" over a PDF file view Weird "dirt" over a PDF file view #4001

[GeetaSarvadnya]

1+ https://community.brave.com/t/google-chrome-like-pdf-inline-pdf-viewer/54283/2

[CalamariDude]

Hi not sure if this is the right place to ask this but: I've been looking forward to this feature and I see it deployed to the nightly builds which I have. How do I update my stable brave browser to the newest release?

Thanks!

[bbondy]

@CalamariDude you can grab Nightly here:
https://brave.com/download-nightly/

Every 3 weeks it'll migrate from Nightly to Dev
Dev to Beta
Beta to Release

There's a different download page for each.

[dionyziz]

Does this fix the issue with the URL bar not showing just the PDF URL also?

[KiaraGrouwstra]

@dionyziz just upgraded to nightly, looks like it does!

edit: I do feel there are a few minor cons to the switch as well:

• no more j/k navigation
• navigating to a bookmark does not add the bookmark to the url hash for sharing

[btlechowski]

Awesome work!

Verification passed on

Brave	0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision	7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS	Windows 7 Service Pack 1 (Build 7601.24494)

Verified test plan from brave/brave-core#2342

Verified that PDF.js extension can still be installed and used as default.

Verified that PDF.js is deleted after update to PDFium

Verified opening pdfs over http and https works

Verification passed on

Brave	0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision	7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS	Linux

• Verified Chrome PDF Viewer is installed and enabled
• Verified able to load pdf file via http/https
• Verfified PDFjs is removed upon upgrade
  
• Verified able to install PDFjs side by side
  

Verified passed with

Brave	0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Mac OS X

• Verified test plan from Use pdfium brave-core#2342
• Verified that PDF.js extension can still be installed and used as default.
• Verified opening pdfs over http and https works
• Verified that PDF.js is deleted after update to PDFium
  
  
• Encountered and logged opened PDFs no longer render after switching to PDFium #5519

[hacker-DOM]

Is there any way to enable the old viewer? I loved its functionality

[KiaraGrouwstra]

@dteiml:

Is there any way to enable the old viewer? I loved its functionality

I think you can just install it from the store.

[bsclifton]

@dteiml what @tycho01 shared is correct - you can install PDF.js from the store 😄
https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm

Once installed, it should work great! Please let us know if you run into any issues

[KiaraGrouwstra]

I don't think this still lets you use PDF.js for local files anymore though... 😞