Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Update to whitelist PDFium #5

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Update to whitelist PDFium #5

merged 1 commit into from
Apr 25, 2019

Conversation

simonhong
Copy link
Member

@simonhong
Copy link
Member Author

cc @bsclifton I can't edit reviewer/assignees list in this repo.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton requested a review from bbondy April 25, 2019 15:57
@bsclifton
Copy link
Member

@pilgrim-brave @bbondy anything needed after the merge?

When I did the PDF.js removal code, it looked like all we needed to do was update DEPS file in brave-core. Can you confirm?

@bsclifton bsclifton merged commit a3a9a76 into master Apr 25, 2019
@bsclifton bsclifton deleted the bsc-remove-pdfjs branch April 25, 2019 15:59
@bbondy
Copy link
Member

bbondy commented Apr 25, 2019

just noting that this will put it on the whitelist for all channels that use this whitelist / blacklist.
I don't think that will cause any problems but just making sure @pilgrim-brave ?

@pilgrim-brave
Copy link
Contributor

AFAIK users can't install PDFium manually, so this should be fine.

@bsclifton
Copy link
Member

@bbondy should only take effect (AFAIK) if DEPS gets updated for other channels, right? When asking above, I couldn't remember if this gets packaged with the CRX packaging... I don't think it is, since it's called out in DEPS (doesn't show in brave://components/ either, so I think we're good)

@bbondy
Copy link
Member

bbondy commented Apr 25, 2019

I think it's used in the local files brave/brave-core-crx-packager, so that means 1 extension for all channels. It's ok though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants