Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip the PDF.js prefix from URLs (fixes brave/brave-browser#368) #1630

Closed
wants to merge 2 commits into from
Closed

Strip the PDF.js prefix from URLs (fixes brave/brave-browser#368) #1630

wants to merge 2 commits into from

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Feb 9, 2019 •
edited
Loading

Fixes brave/brave-browser#368.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Open https://fmarier.org/test.pdf and ensure the URL bar displays https://fmarier.org/test.pdf.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@fmarier fmarier added this to the 0.62.x - Nightly milestone Feb 9, 2019
@fmarier fmarier self-assigned this Feb 9, 2019
@fmarier fmarier requested a review from bridiver February 9, 2019 01:01
@fmarier
Copy link
Member Author

fmarier commented Feb 9, 2019

@bridiver, this pull request was re-written following your review comments in #1074 (comment).

Replacing the stripped-down PDF.js extension with the real one was suggested by @bbondy in https://bravesoftware.slack.com/threads/convo/C7VLGSR55-1549589742.278400/. I did some git blame digging but couldn't find any explanation for the custom version of PDF.js. The size difference is 2 MB v. 765 KB.

Removing the pdfjs.pem file didn't seem to have any effect on any of the existing tests. I'm not entirely sure what its purpose was, though there is a general explanation in 2728711.

@fmarier fmarier force-pushed the issue368 branch 2 times, most recently from 2ba3b46 to 37aad59 Compare February 23, 2019 01:47
@fmarier
Copy link
Member Author

fmarier commented Feb 23, 2019

Test URLs:

@fmarier fmarier mentioned this pull request Mar 1, 2019
Closed
@bbondy
Copy link
Member

bbondy commented Mar 5, 2019

@fmarier I think this should be 0.63.x since the PR is against master. I adjusted it.

@bbondy bbondy modified the milestones: 0.62.x - Dev, 0.63.x - Nightly Mar 5, 2019
@fmarier
Copy link
Member Author

fmarier commented Mar 22, 2019

This will need to be re-written in light of #2024.

@bbondy
Copy link
Member

bbondy commented Mar 22, 2019

I think this is probably wontfix because of brave/brave-browser#3846 ?

@fmarier
Copy link
Member Author

fmarier commented Mar 22, 2019

I think this is probably wontfix because of brave/brave-browser#3846 ?

Indeed. Let's close this.

@fmarier fmarier closed this Mar 22, 2019
@fmarier fmarier removed their assignment Mar 22, 2019
@fmarier fmarier removed this from the 0.64.x - Nightly milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening PDF in a tab shows chrome://extension URL and PDF extension favicon
3 participants
@fmarier @bbondy @bridiver