Incognito still being generated from translated strings

[bbondy]

This issue #738 changed Incognito -> Private for all source strings, but the translations are still being preserved. I think we need to add some 1 time code to clear out the translations, and maybe also to make sure we don't re-upload them when we do npm run push_l10n

[LaurenWags]

Still reproduces with

Brave	0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision	416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS	macOS Version 10.13.6 (Build 17G5019)

Noticed English (UK) uses Incognito instead of Private terminology.

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 0.70.116 - Encountered the issue for UK, INDIA and Germany locales

Germany:

[btlechowski]

I closed the wrong issue. Sorry.

[btlechowski]

Still reproducible on Linux #6564

Affected locales: en_GB/en_AU/en_NZ
Not affected locales: en_US

Brave	0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision	2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS	Ubuntu 18.04 LTS

[petemill]

Hmm, I'm investigating this but not sure I understand what happened yet.

About a year ago, we would have submitted changes in the source US strings from e.g. "New Incognito Window" to "New Private Window".

However, in transifex looks like we (or it automatically) accepted the original translations for certain languages. So British English has the string translated (and approved) as "New Incognito Window"

Similarly, spanish

But German does have the correct translation

[bsclifton]

Fixed with brave/brave-core#3922

[GeetaSarvadnya]

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Locale UK

Locale India

Locale Germany

Locale Australia

Locale New Zealand

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

en_GB

en_AU

en_NZ

de_DE

Verified passed with

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

EN UK

EN AU

DE