Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i cant login Crypto Wallets #6442

Closed
tharinduvindula opened this issue Oct 11, 2019 · 46 comments · Fixed by brave/ethereum-remote-client#91 or brave/ethereum-remote-client#114
Closed
Assignees
Labels
feature/ethereum-remote-client priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include

Comments

@tharinduvindula
Copy link

tharinduvindula commented Oct 11, 2019

Description

Steps to Reproduce

  1. i can't log brave Crypto Wallet
  2. i can't Restore account
  3. i can't do anything in brave Crypto Wallet, only show that interface

Actual result:

Capture

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Can't reproduce the issue. Can you please add the browser details and check brave://components for Crypto Wallets version?

@srirambv srirambv added feature/web3/wallet Integrating Ethereum+ wallet support needs-more-info The report requires more detail before we can decide what to do with this issue. labels Oct 11, 2019
@ivigamberdiev
Copy link

ivigamberdiev commented Oct 13, 2019

I have same issue. My case:

  1. I created wallet and wrote password
  2. But accidentally closed the tab with wallet w/o entering a seed-phrase
  3. When try login or restore nothing happening
    I checked Metamask for this bug, but in this test case it open tab with entering a seed-phrase. Looks like Brave specific bug.
Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}

Crypto Wallets - Version: 1.0.10

@tharinduvindula
Copy link
Author

I type my correct password but it after log show dashboard and after few seconds it reroute to login page

@srirambv srirambv added needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 16, 2019
@srirambv
Copy link
Contributor

@arosboro
Copy link

I tried importing my metamask 12 word mnemonic phrase, but got the response that 12 words was not long enough (16, or 24 I believe). I quit, came back to this. When I enter the password I remember, I get: MetamaskController - No HD Key Tree found

@srirambv
Copy link
Contributor

Could you guys check what component version is in the browser? You can check the component version from brave://component. The current stable release is 1.0.11. Please click on Check for update if your browser is having an older version. Once updated restart the browser and check if you are able to login

@arosboro
Copy link

@srirambv I don't have a path at brave://component, but brave://version says:

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}

@arosboro
Copy link

arosboro commented Oct 20, 2019

Nevermind, found it at brave://components.
Crypto Wallets - Version: 1.0.11
Status - Up-to-date

I recall that the release with crypto wallets came out, I imported my metamask seed unsuccessfully, and then another update came out with the login issue.

@tharinduvindula
Copy link
Author

my brave://wallet/ is not work for me but i can use meta mask

@ivigamberdiev
Copy link

This problem is actual, even after update to Brave Version 0.70.121. Pls reopen it.

@srirambv
Copy link
Contributor

Reopening the issue as this needs investigation as to why the login is failing.

@srirambv srirambv reopened this Oct 25, 2019
@arosboro
Copy link

Can someone from the team at least provide instruction on how to wipe the crypto wallets component data/seed and start from scratch?

@Brave-Matt
Copy link

@liberuum
Copy link

Got the same issue after updating to the latest version
Version 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)

@Brave-Matt
Copy link

Another on from Community:
https://community.brave.com/t/re-crypto-wallet-blank-page/85967/8

@srirambv what's the status on this?

@computerpoet
Copy link

I have same issue. My case:

  1. I created wallet and wrote password
  2. But accidentally closed the tab with wallet w/o entering a seed-phrase
  3. When try login or restore nothing happening
    I checked Metamask for this bug, but in this test case it open tab with entering a seed-phrase. Looks like Brave specific bug.

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
Crypto Wallets - Version: 1.0.10

Similar issue here, when creating the wallet, at the verification phase i could not choose the seed phrase as it was blank, closed the window, then can't even reset or reimport anything.

@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2019

Could someone having login issues try this

  1. Login with the correct password
  2. When it says its incorrect
  3. Close and relaunch the browser
  4. Try logging again with correct password and check if it works

@ryanml ryanml self-assigned this Dec 2, 2019
@aaron-hanson
Copy link

Could someone having login issues try this

  1. Login with the correct password
  2. When it says its incorrect
  3. Close and relaunch the browser
  4. Try logging again with correct password and check if it works

Tried that, no luck. Also, is there some way to reset things completely to try and set up from scratch with a new password, so we can at least get around this?

@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2019

@aaron-hanson just to be sure the crypto wallet component is up to date right? Could you check the version in brave://components? The current released version is 1.0.13

is there some way to reset things completely

Should be done as part of #5741

@aaron-hanson
Copy link

@aaron-hanson just to be sure the crypto wallet component is up to date right? Could you check the version in brave://components? The current released version is 1.0.13

is there some way to reset things completely

Should be done as part of #5741

Yep, it showsCrypto Wallets - Version: 1.0.13

@BadseyBurger
Copy link

I am also having this problem. The workaround further up the thread doesn't work for me. Help please :)

@foiba
Copy link

foiba commented Jan 31, 2020

Exact same problem for almost a month now. Nothing helps. I log in with password, screen flashes showing a dropdown for about .3s in upper right corner and immediately redirects to login. I tried typing a random password and that shows as incorrect password. So it definitely recognizes my actual password as correct. No workarounds help so far. Great browser, hoping for a patch or a workaround that works around!

@denisediniz
Copy link

Same here. Steps to reproduce the issue (everything up-to-date)

  1. Create a new local wallet with a new password;
  2. Close the tab of the seed phrase confirmation page;
  3. Go back to the crypto-wallets page: the password immediately redirects to login and there's no way to restore, remove or create a new account.

the seed phrase confirmation page doesn't scroll down in Win10 desktop.

@ryanml
Copy link
Contributor

ryanml commented Feb 1, 2020

Thank you all for your reports, it’s helpful as I try to see exactly what’s going on. @BadseyBurger @foiba - can you confirm if you backed out of the seed confirmation page like @denisediniz and @aeikenberry ?

@ryanml ryanml reopened this Feb 1, 2020
@DruPlusDru
Copy link

I am also having this same problem. The seed confirmation page froze up so I was unable to scroll the page and complete the assigned task. I closed out the window and am having the same issue as @denisediniz and @aeikenberry

@s-ben
Copy link

s-ben commented Feb 2, 2020

If it's any help, was locked out of MetaMask for a web3 site I was trying to access (Gitcoin), even after disabling Brave Crypto Wallets and restarting Brave. Restarted computer (OSX 10.14.6) and only then did MetaMask successfully connect.

@dhniels
Copy link

dhniels commented Feb 3, 2020

I'm having this problem as well. The seed confirmation screen only showed 4 words and I couldnt get past it so i closed the window and now i get the login screen. If i enter the wallet password I created, it flashes the wallet very briefly before going back to the same login screen. Can't get past this screen or do really anything at all now. Clicking "Restore Account" does nothing.

@ryanml
Copy link
Contributor

ryanml commented Feb 3, 2020

@BadseyBurger @foiba @denisediniz @aeikenberry @DruPlusDru @s-ben @dhniels

Thank you all so much for your patience, I have identified a fix for this and posted it here: brave/ethereum-remote-client#114

We have also fixed the scroll issue on the confirm seed phrase page. You'll now be able to see everything on certain viewports. The fix will also backfix your situations so login will work as expected, no resets needed. This fix is set go out by the end of this week.

Here is a video of the fix (sluggishness is due to testing on a debug build):
https://ryanlane.se/img/login-fix.gif

@ryanml
Copy link
Contributor

ryanml commented Feb 12, 2020

@BadseyBurger @foiba @denisediniz @aeikenberry @DruPlusDru @s-ben @dhniels - please see https://www.reddit.com/r/brave_browser/comments/f2uqsv/crypto_wallet_is_one_giant_bug/fhet7nf/ regarding the update. It would be great if you guys could check it out and attempt to log in.

@foiba
Copy link

foiba commented Feb 13, 2020

@ryanml I tried refreshing the cryptowallet tab and opening a new one and it failed to work however i was able to log in when I restarted Brave. It doesn't show the BAT I've accumulated and been rewarded but that's something else. Thank you!

@denisediniz
Copy link

denisediniz commented Feb 13, 2020

Thank you! The Restore account link redirects to the right page (the Restore page isn't scrollable yet). I can't login right now but just because I made the workaround to delete my local test wallet and I can't create a new wallet, so right now I can't test the login function. I'm going to follow the #7677 issue.

@ryanml
Copy link
Contributor

ryanml commented Feb 13, 2020

@denisediniz Are you not able to submit the account restore form due to a scrolling issue? Can I see a screenshot of this? Do you have your restore phrase that you can use?

@denisediniz
Copy link

Unfortunately I don't have the restore phrase for the deleted wallet. I had removed my local testing wallet through the workaround of deleting the odb... folders within User Data to create another one. As I'll need to create another account to login, with new password and restore phrase, I'm watching the other issue. The Restore acc page isn't scrollable but it works well through tabbing into the fields. Ty =)

@ryanml
Copy link
Contributor

ryanml commented Feb 13, 2020

@denisediniz Got it, I haven't heard any other reports of scrolling issues on the Restore page but I will file an issue for it. I'd like to help you get back and running on Crypto Wallets, can you email me at rlanese at brave.com so I can work with you? Thanks!

@HikariWS
Copy link

HikariWS commented Apr 6, 2020

I'm having similar issue. I just installed Brave a few days ago, so everything's updated.

I installed MetaMask and went to connect my Trezor to it. It was a very easy process on Chrome, but on Brave I keep on loading message on https://connect.trezor.io/7/popup.html#loading

Same thing happens for chrome://wallet/ when I try to connect my Trezor.

Oddly, MEW works and is able to connect.

As it always worked on Chrome flawlessly, my bet is the issue is on Brave. I wanna move out of Chrome because it bypasses pihole and keeps showing banners, it's sad Brave isn't working with Trezor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment