Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset data / delete account option to Crypto Wallets #5741

Closed
Miyayes opened this issue Aug 20, 2019 · 18 comments · Fixed by brave/brave-core#4364 or brave/ethereum-remote-client#106
Assignees
Labels
feature/ethereum-remote-client OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 20, 2019

Description

Crypto wallets should feature an option to reset all data, or delete accounts. At the moment, there is only a pull request to allow disabling/enabling, but not for resetting or deleting data.

See: https://www.reddit.com/r/brave_browser/comments/cszx7s/how_do_i_delete_my_cryptowallet_settings_and/

Test Plan

(These tests should be followed with the origin wallet being both freshly created and restored)

  1. On the login screen, click Reset Crypto Wallets below the form
  2. Confirm the reset screen renders
  3. Confirm that only by entering the unlock phrase are you allowed to access the reset button
  4. Upon hitting the action, the browser will restart and all Crypto Wallets tabs will close
  5. Confirm navigating to brave://wallet shows a fresh welcome view
  6. Confirm that you can both create and restore a wallet after this point
  7. From both of those points, attempt smoke test of behavior within the account (IE transactions, account restore, backup, re-reset)
@NejcZdovc NejcZdovc added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 20, 2019
@bbondy
Copy link
Member

bbondy commented Aug 23, 2019

I think you can add a second account then delete the first.

@bbondy
Copy link
Member

bbondy commented Aug 23, 2019

Maybe a clear all extension state would be nice though.

@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Aug 23, 2019
@ryanml ryanml self-assigned this Sep 16, 2019
@ryanml
Copy link
Contributor

ryanml commented Sep 17, 2019

This will amount to an action in the Advanced settings tab. There definitely should be a confirmatory modal letting the users know that they are essentially going to reset Crypto Wallets to how it was when they first made an account. cc: @tomlowenthal && @jamesmudgett for copy and any extra UX we may need.

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Sep 20, 2019

Will this work from the password-entry screen? That seems like the most important place to support a reset.

@dbarev
Copy link

dbarev commented Oct 28, 2019

manual workaround is to delete the following folder (under windows):
%profile data%/[Default]\Local Extension Settings\odbfpeeihdkbihmopkbjmoonfanlbfcl
whereas %profile data% is the path to the brave data folder for the currently logged user (in windows) and [Default] is the profile username in Brave

@heueristik
Copy link

Is there a workaround for macOS too?

@thechadc
Copy link

manual workaround is to delete the following folder (under windows):
%profile data%/[Default]\Local Extension Settings\odbfpeeihdkbihmopkbjmoonfanlbfcl
whereas %profile data% is the path to the brave data folder for the currently logged user (in windows) and [Default] is the profile username in Brave

to remove wallet from command line.

cd %localappdata%\BraveSoftware\Brave-Browser\User Data\Default\Local Extension Settings
rmdir /Q /S odbfpeeihdkbihmopkbjmoonfanlbfcl

@thechadc
Copy link

manual workaround is to delete the following folder (under windows):
%profile data%/[Default]\Local Extension Settings\odbfpeeihdkbihmopkbjmoonfanlbfcl
whereas %profile data% is the path to the brave data folder for the currently logged user (in windows) and [Default] is the profile username in Brave

After deleting, Im getting an error KeyringController - No account found on keychain reset when creating a new local wallet. Any way to reset this?

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 19, 2019
@jaclas
Copy link

jaclas commented Nov 25, 2019

After deleting, Im getting an error KeyringController - No account found on keychain reset when creating a new local wallet. Any way to reset this?

I have the same problem and the same error.
Is there a way to delete/restart "Crypto Wallets" in Brave?

@dbarev
Copy link

dbarev commented Nov 26, 2019

@jaclas, @thechadc I tried to reproduce your issue but failed. Here is what I do:

  1. Download portable brave (I do not want to mess my existing install) from https://portapps.io/app/brave-portable/
  2. Start and initialize wallet.
  3. Shutdown Brave
  4. Execute steps in the above post for the workaround
  5. Restart Brave - wallet can be re-initialized.

This works consistently under Windows on different machines. Do not have time to test under Linux but should work similarly.

@jaclas
Copy link

jaclas commented Nov 26, 2019

@dbarev
The portable version of brave doesn't have a directory:

\BraveSoftware\Brave-Browser\User Data\Default\Local Extension Settings\odbfpeeihdkbihmopkbjmoonfanlbfcl

but only:

\BravePortable\data\odbfpeeihdkbihmopkbjmoonfanlbfcl

which is different from the directory specified in the solution.

Try with fully installed Brave Browser and correct directory.

@jolestar
Copy link

jolestar commented Dec 31, 2019

I just remove ~/Library/Application Support/BraveSoftware/Brave-Browser/Default/Local Extension Settings/odbfpeeihdkbihmopkbjmoonfanlbfcl at Mac.
The wallet can be re-initialized.
Please backup before remove.

update:
getting an error KeyringController - No account found on keychain.

@jrogers512
Copy link

Is there a workaround for macOS too?

rm -r ~/Library/Application\ Support/BraveSoftware/Brave-Browser/odbfpeeihdkbihmopkbjmoonfanlbfcl/

@srirambv
Copy link
Contributor

Moving to 1.0.18 as per triage discussion

@kirkins
Copy link

kirkins commented Sep 28, 2020

Anyway to reset crypto wallets now? (used default but now want to import)

@kirkins
Copy link

kirkins commented Sep 28, 2020

I see it now. I just had to lock my account and where you would enter your password there is a link to import from seed.

@rapkyt
Copy link

rapkyt commented Oct 6, 2020

After deleting, Im getting an error KeyringController - No account found on keychain reset when creating a new local wallet. Any way to reset this?

I have the same problem and the same error.
Is there a way to delete/restart "Crypto Wallets" in Brave?

I created my wallet with a random password that I thought I've sa.ved but I didn't, now I want to create a new one from scratch, but I can't.

@gszep
Copy link

gszep commented May 4, 2021

This is still a problem in Version 1.23.75 Chromium: 90.0.4430.93 (Official Build) (64-bit) for Ubuntu. Deleting the odbfpeeihdkbihmopkbjmoonfanlbfcl folder in the local settings breaks the extension

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ethereum-remote-client OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include
Projects
None yet