Backend Work for Crypto Wallets reset feature #4364
Conversation
ryanml
force-pushed
the
reset-crypto-wallets
branch
2 times, most recently
from
0a75e5c
to
53c6327
Compare
ryanml
force-pushed
the
reset-crypto-wallets
branch
3 times, most recently
from
781c5fc
to
6f397b0
Compare
| GURL url = web_contents->GetURL(); | ||
| if (url.SchemeIs(content::kChromeUIScheme) && | ||
| url.host() == ethereum_remote_client_host) { | ||
| web_contents->Close(); |
There was a problem hiding this comment.
Does this actually get rid of the tab_strip's webcontents too? if so this might cause some wonkiness with the iterator on the count.
There was a problem hiding this comment.
I'll do some tests and double check, I'll report back 👍
ryanml
force-pushed
the
reset-crypto-wallets
branch
from
6f397b0
to
da3a537
Compare
Adding service and controller for brave_wallet
ryanml
force-pushed
the
reset-crypto-wallets
branch
from
da3a537
to
6e7411e
Compare
| #include "components/keyed_service/core/keyed_service.h" | ||
|
|
||
| namespace base { | ||
| class SequencedTaskRunner; |
There was a problem hiding this comment.
why is this here? It isn't referenced anywhere in the header
| BraveWalletService::BraveWalletService(content::BrowserContext* context) | ||
| : context_(context), | ||
| controller_(new BraveWalletController(context)), | ||
| weak_factory_(this) { |
There was a problem hiding this comment.
why does this have a weak ptr? It is never used for anything
| } | ||
|
|
||
| // static | ||
| BraveWalletService* BraveWalletServiceFactory::GetForProfile(Profile* profile) { |
There was a problem hiding this comment.
this factory needs to go in brave/browser/brave_wallet
There was a problem hiding this comment.
I moved that already in a diff PR a few weeks ago
|
Has the fix been released into Brave stable yet? Currently |
|
This PR closes brave/brave-browser#5741 however there is no hint how to actually remove/initialize Brave Wallet
|
Partially fixes: brave/brave-browser#5741
Fixes: brave/brave-browser#7716
After the deletion of the DB entry, two things have to happen:
brave://walletneed to closeSubmitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Note: The Extension at this time lacks the
"management"permissions allowing programmatic reload, so the above snippet will not work. However, these steps can be used to verify functionality:brave://walletbrave://wallet, confirm state is freshReviewer Checklist:
After-merge Checklist:
changes has landed on.