Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text displayed during Ad earning claim process - follow up to 5578 #6359

Closed
LaurenWags opened this issue Oct 8, 2019 · 7 comments · Fixed by brave/brave-core#3729
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 8, 2019

Description

Follow up to #5578

Per discussion on slack, @mandar-brave and @jsecretan to provide the correct text to be displayed during the Ad earning claim process. This includes:

  1. Text displayed on BAT logo Notification
  2. Text displayed after captcha is correctly solved to claim Ad rewards from the panel/notification (issue no longer able to claim Ad Rewards from panel #6357 was resolved in 0.70.115, screenshot added below)
  3. Text displayed on claim banner on brave://rewards page
  4. Text displayed after captcha is correctly solved to claim Ad rewards on brave://rewards page
  5. Any other text that needs to be changed

See screenshots in #5578 (comment)

Steps to Reproduce

  1. Set up ad earnings to be claimed
  2. Claim from panel/brave://rewards page to confirm that text is correct.

Actual result:

  1. Text displayed on BAT logo Notification

1

  1. Text displayed after captcha is correctly solved to claim Ad rewards from the panel/notification (issue no longer able to claim Ad Rewards from panel #6357 was fixed)

Screen Shot 2019-10-14 at 10 48 02 AM

  1. Text displayed on claim banner on brave://rewards page

3

  1. Text displayed after captcha is correctly solved to claim Ad rewards on brave://rewards page

4

Expected result:

TBD by @mandar-brave and @jsecretan

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@ryanml
Copy link
Contributor

ryanml commented Oct 17, 2019

Updated text provided

image (9)

@NejcZdovc
Copy link
Contributor

@ryanml what about notification screen in the panel and on settings page? are they ok?

@NejcZdovc NejcZdovc added this to the 0.73.x - Nightly milestone Oct 17, 2019
@ryanml
Copy link
Contributor

ryanml commented Oct 17, 2019

@NejcZdovc - yep this is the only one I got updates for cc: @bradleyrichter @mandar-brave

@bradleyrichter
Copy link

@NejcZdovc @mandar-brave @ryanml

Corrected mockup:

image

@LaurenWags
Copy link
Member Author

QA/Blocked until we get a new build. Will be available in 0.71.107` and above.

@LaurenWags
Copy link
Member Author

Removed QA/Blocked as build 0.71.107 is available.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 4, 2019

Verification passed on

Brave 0.71.108 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-11-04 at 10 53 40 AM

Screen Shot 2019-11-04 at 10 54 02 AM

Screen Shot 2019-11-04 at 10 59 55 AM

Screen Shot 2019-11-04 at 11 00 14 AM

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants