Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave profile icons #6443

Closed
karenkliu opened this issue Oct 11, 2019 · 1 comment · Fixed by brave/brave-core#3771
Closed

Update Brave profile icons #6443

karenkliu opened this issue Oct 11, 2019 · 1 comment · Fixed by brave/brave-core#3771

Comments

@karenkliu
Copy link

karenkliu commented Oct 11, 2019

Test plan

See brave/brave-core#3771

Description

Update our current not-scalable solid color Brave profile icons with new pattern/color ones.

Designs

These are the new ones:
profile icons-rainbow ref

Assets

profile-icons-names.txt
assets.zip

@LaurenWags
Copy link
Member

LaurenWags commented Oct 23, 2019

Verified passed with

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-23 at 10 14 11 AM

  • Confirmed all 35 icons are selectable (including the default).
  • Confirmed when a 2nd profile is created after a fresh user data directory is used, the first profile uses the new default icon (the first icon in set above). Subsequent profiles uses random other icons in set.

Screen Shot 2019-10-23 at 10 15 19 AM

  • Confirmed when a user data directory from the previous Brave browser version is used which has multiple profiles with brave avatar icons selected, those profiles still maintain their existing icon.
    Set up in 0.69.135:

Screen Shot 2019-10-23 at 10 38 09 AM

After upgrade to 0.70.121:
Screen Shot 2019-10-23 at 10 40 06 AM

  • Confirmed if upgrading from a version with Brave custom icons (0.70.120) to a version with new icon set from above, no error or blank avatars were observed. Old Brave custom icons were replaced with new icons from above set.
    0.70.120:

Screen Shot 2019-10-23 at 12 45 37 PM

0.70.121:
Screen Shot 2019-10-23 at 12 46 33 PM

Verification passed on

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified test plan from A new avatar icon set brave-core#3771

  • Verified when upgrading from 0.69.x: placeholder image is changed, but previously selected images are not
    image
    image

  • Verified only new icons are displayed when choosing a new profile avatar in Settings
    image

  • Verified only new icons are displayed in Manage Profiles popup
    image

  • Verified all 35 icons are selectable (including the default).

  • Verified subsequent profiles uses random other icons in set.

  • Verified when upgrading from 0.70.120: placeholder image is changed to new icons
    image
    image

Verification passed on

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Confirmed only new icons are displayed when choosing a new profile avatar in Settings

image

  • Confirmed all 35 icons are selectable (including the default).
  • Confirmed when a 2nd profile is created after a fresh user data directory is used, the first profile uses the new default icon (the first icon in set above). Subsequent profiles uses random other icons in set.

image

  • Confirmed when a user data directory from the previous Brave browser version is used which has multiple profiles with brave avatar icons selected, those profiles still maintain their existing icon.
    Set up in 0.69.135:

image

After upgrade to 0.70.121:

image

  • Confirmed if upgrading from a version with Brave custom icons (0.70.120) to a version with new icon set from above, no error or blank avatars were observed. Old Brave custom icons were replaced with new icons from above set.
    0.70.120:

image

0.70.121:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment