Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide Chromium icons and replace with Brave profile icons #5207

Closed
rebron opened this issue Jul 10, 2019 · 11 comments · Fixed by brave/brave-core#3165
Closed

hide Chromium icons and replace with Brave profile icons #5207

rebron opened this issue Jul 10, 2019 · 11 comments · Fixed by brave/brave-core#3165

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 10, 2019

Description

Hide Chromium icons and replace with our Brave profile icons.

Current Experience:

Existing Chromium provided profile icons should not be displayed to our users.
Screen Shot 2019-07-10 at 2 42 17 PM

New Profile icons:

[placeholder, design in progress]

image

@rebron rebron added feature/profile-manager priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 10, 2019
@rebron rebron changed the title Hide Chromium icons and replace with Brave profile icons hide Chromium icons and replace with Brave profile icons Jul 10, 2019
@ghost
Copy link

ghost commented Jul 12, 2019

why not?

@harvey-withington
Copy link

I would prefer to simply upload my own icon from my local file system. Please make this an option.

@rebron
Copy link
Collaborator Author

rebron commented Jul 15, 2019

@KrackerKarakas Uploading icons or placing them in the right folder so they're picked up in the UI are options we're exploring. We know people want to be able to use their own icons/avatars.

@petemill petemill self-assigned this Aug 9, 2019
@bradleyrichter
Copy link

BTW - any people/profile icons you were already using will be retained so that you don't lose your muscle memory for those.

@cupcakearmy
Copy link

How does one change the current name or icon? I can only set it wen I create a new profile

@LaurenWags
Copy link
Member

Per discussion with @rebron this one is QA/Blocked until some changes are implemented. @rebron can you provide the follow up issue with the changes once you have it? Thanks!

@GeetaSarvadnya
Copy link

Verification passed on

Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@LaurenWags
Copy link
Member

Removed QA Pass-Win64 label per discussion with @GeetaSarvadnya since we are still waiting on changes for this issue.

@rebron @petemill any updates to the expected changes?

@LaurenWags
Copy link
Member

Removing QA/Blocked label as we now have a build with #6443

@LaurenWags
Copy link
Member

Removing release-notes/include label as #6443 has the new icons being used - will use that issue in the release notes.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 23, 2019

Verified passed with

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)

3165-1

After upgrade to 0.70.121:
3165-2

  • Confirmed Initial profile is created with Brave placeholder

3165-4

  • Confirmed Subsequent profiles are created with random images

3165 - 3

3165-5

  • Confirmed User can select brave icons in Settings

6

7

8

  • Confirmed User can select brave icons in Manage Profiles popup

9

10

11

12

Verification passed on

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified test plan from New set of brave-specific profile icons and icon functionality brave-core#3165

  • Verified when upgrading from 0.69.x: placeholder image is changed, but previously selected images are not
    image
    image

  • Verified Initial profile is created with Brave placeholder
    image

  • Verified Subsequent profiles are created with random images

  • Verified Confirmed User can select brave icons in Settings
    image

  • Verified User can select brave icons in Manage Profiles popup
    image

Verification passed on

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

After upgrade to 0.70.121:

image

  • Confirmed Initial profile is created with Brave placeholder
    image

  • Confirmed Subsequent profiles are created with random images

image

  • Confirmed User can select brave icons in Settings

image

image

  • Confirmed User can select brave icons in Manage Profiles popup
    image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants