Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile avatars getting button style overrides instead of avatar circles #3568

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 1, 2019

This restricts our button style overrides to only buttons without a style attribute.

Fix brave/brave-browser#5977

Submitter Checklist:

Test Plan:

On brave/brave-browser#5977

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill self-assigned this Oct 1, 2019
@bsclifton bsclifton added this to the 0.72.x - Nightly milestone Oct 2, 2019
@bsclifton
Copy link
Member

CI passed on all but Windows; gonna give that a restart

@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 2, 2019
@bsclifton
Copy link
Member

Would need to be uplifted to same release as brave/brave-browser#5207 (which is 0.70.x)

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works great 😄 Thanks!

@petemill
Copy link
Member Author

petemill commented Oct 2, 2019

Technically this fixes a regression present in 0.69 via c77 (and the UI allowed to be reached via #3140), but since that's near release then aiming for 0.70.x is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium WebUI buttons are over-eagerly re-styled for brave style
2 participants