Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Replace MetaFox icon from connect wallet popup #6534

Closed
srirambv opened this issue Oct 17, 2019 · 2 comments · Fixed by brave/ethereum-remote-client#86 or brave/ethereum-remote-client#87

Comments

@srirambv
Copy link
Contributor

Description

Remove/Replace MetaFox icon from connect wallet popup

Steps to Reproduce

  1. Create a wallet
  2. Connect wallet popup shows MetaFox icon

Actual result:

image

Expected result:

No Metamask branding

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel?Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Oct 31, 2019

@ryanbr @bbondy was this merged into https://github.com/brave/ethereum-remote-client/releases/tag/v0.1.18? I'm still seeing the MM icon in the popup windows. Doesn't seem to be resolved:

  • macOS 10.14.6 x64 - Reproduced
  • Win 10 x64 - Reproduced

@srirambv are you seeing the same thing on Linux?

Examples:

Screen Shot 2019-10-30 at 11 07 04 PM

Screen Shot 2019-10-30 at 11 04 58 PM

@srirambv
Copy link
Contributor Author

srirambv commented Nov 20, 2019

Verification passed on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux
Component 0.1.29
  • Verified MetaFox icon is not shown on connect wallet popup
    image

Verification PASSED on macOS 10.15.1 x64 using 1.0.1 Chromium: 78.0.3904.108 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.29.

Screen Shot 2019-11-22 at 3 41 01 PM

Screen Shot 2019-11-22 at 3 40 34 PM


Verification passed on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1903 (Build 18362.418)
Component 0.1.29

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment