Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaFox icon is not removed on upgrade[Followup to #6534] #7069

Closed
srirambv opened this issue Nov 23, 2019 · 3 comments · Fixed by brave/ethereum-remote-client#121
Closed

Comments

@srirambv
Copy link
Contributor

Description

MetaFox icon is not removed on upgrade[Followup to #6534]

Steps to Reproduce

  1. Install older component version where MetaFox icon is shown
  2. Upgrade to 1.0.13
  3. Popup still shows MetaFox icon

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Ethereum Remote Component 0.1.29

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 20, 2019
@ryanml
Copy link
Contributor

ryanml commented Jan 19, 2020

@srirambv can you double check this one? I don't think it's an issue anymore.

@srirambv
Copy link
Contributor Author

Waiting for the device to be shipped. Will check and update the issue

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.6.18 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
Component 0.1.43
  • Verified installing component 1.0.10 shows MetaFox icon. Upgrading to component 0.1.43 removes the MetaFox icon
    image

Verification passed on

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1809 (Build 17763.914)
Component 0.1.43
  • Verified installing component 1.0.10 shows MetaFox icon. Upgrading to component 0.1.43 removes the MetaFox icon
    image

Verification passed on

Brave 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Linux
Component 0.1.43
  • Verified installing component 1.0.10 shows MetaFox icon. Upgrading to component 0.1.43 removes the MetaFox icon
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants