Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client side changes of sync compaction #6552

Closed
darkdh opened this issue Oct 18, 2019 · 4 comments · Fixed by brave/brave-core#3749
Closed

Implement client side changes of sync compaction #6552

darkdh opened this issue Oct 18, 2019 · 4 comments · Fixed by brave/brave-core#3749

Comments

@darkdh
Copy link
Member

darkdh commented Oct 18, 2019

There will be a compaction API that closes
brave/sync#341

Client will call compaction API every week

@btlechowski
Copy link

Blocked on #6941

@kjozwiak
Copy link
Member

Removing QA/Blocked as both brave/brave-core#4407 & brave/brave-core#4408 have been merged. Once we get a new 1.3.x build that's > 1.3.100, QA should be able to verify this issue.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 7, 2020

Verification on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Update
Device A:
image

Device C
image

Delete
Device A
image

Device C
image

@AlexeyBarabash
Copy link
Contributor

@GeetaSarvadnya I was able to verify Delete case:
seeing exactly "sync-debug" message="got 1 decrypted records in BOOKMARKS after 0"
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment