-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Brave Sync UI to allow one device in chain #6941
Comments
Since brave/brave-core#3988 had been merged into |
#6941 (comment) the PR was merged to Beta. Steps to Reproduce
Actual result:During initial sync creation "Choose device type" is automatically closed. Note: You can still add devices after the sync was created
cc @rebron @bsclifton @brave/legacy_qa |
@cezaraugusto Is your pr solving this completely or are you stuck in review? |
@btlechowski thanks for reporting. on it right now. @rebron yes there is a PR open for this but @AlexeyBarabash pointed me out that additional work was required, which I'm working on at this very moment. |
milestone changed to match commit channel |
Verification passed on
Verified clicking Verification passed on
Verified clicking Verification passed with
Verified clicking Encountered #8314 while testing. |
Marked as |
Description
This issue is an required addition for PR brave/brave-core#3988 .
General notes:
Sync should allow to have just one device in the chain.
This will help to avoid the situation mentioned in #6504. Or with these hypothetical STRs:
**Required changes: **
View Sync Code
dialog.View Sync Code
is being shown, but there are less than two devices, then when the dialog is closed by cancel, SyncUI should not call Reset, and should just show the regular devices list screen and buttons.@bradleyrichter, @darkdh , @bridiver could you please review the requested changes?
@cezaraugusto,
you should work in branch of https://github.com/brave/brave-core/tree/sync_prefs_redo_issue_6504 , because it contains the service side changes to allow to have less than two devices in chain.The commitChanges in sync UI to allow test of service - subject to be redone
- should be removed because it is just my attempt to allow page work when < 2 devices, so it is rough and not correct.The text was updated successfully, but these errors were encountered: