Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3628 offline reset #4089

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Fix 3628 offline reset #4089

merged 2 commits into from
Nov 28, 2019

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Nov 27, 2019

Submitter Checklist:

Fixes brave/brave-browser#3628

Test Plan:

  1. Create sync chain between devices A and B
  2. Turn off the internet connection on deviceA
  3. Press Leave Sync Chain button on deviceA
  4. Refresh page brave://sync on deviceA
    This point is required until sync UI is not modified to meet requirement one or more devices in chain (Modify Brave Sync UI to allow one device in chain brave-browser#6941).
  5. Expected: deviceA is not in the chain, brave://sync on deviceA shows initial page
  6. Expected: on deviceB in devices list, there are two devices: deviceA (which is zombie) and deviceB.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash AlexeyBarabash merged commit 87000ca into master Nov 28, 2019
@AlexeyBarabash AlexeyBarabash deleted the fix_3628_offline_reset branch November 28, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time out sync reset if device is offline
2 participants