Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar color doesn't change from dark to light in nigthly #6660

Closed
sebutek opened this issue Oct 30, 2019 · 1 comment
Closed

Search bar color doesn't change from dark to light in nigthly #6660

sebutek opened this issue Oct 30, 2019 · 1 comment

Comments

@sebutek
Copy link

sebutek commented Oct 30, 2019

Description

Searchbar text is not readable. Also the text color of the autocompletion box is wrong.

Steps to Reproduce

  1. Switch from dark mode to light mode
  2. Search something with CTRL + F (Also in the autocompletion box the text is white in light mode)

Actual result:

Image

Expected result:

Text to be readable

Reproduces how often:

Every time. Works in 0.70.121 but not in nightly

Brave version (brave://version info)

Brave 0.73.26 Chromium: 78.0.3904.70 (Official Build) nightly (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1903 (Build 18362.418)
JavaScript V8 7.8.279.17
Flash (Disabled)
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.70 Safari/537.36
Command Line "C:\Program Files (x86)\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=WebUIDarkMode,NewExtensionUpdaterService,PasswordImport,SimplifyHttpsIndicator --disable-features=UnifiedConsent,NotificationTriggers,AudioServiceOutOfProcess,SmsReceiver,LookalikeUrlNavigationSuggestionsUI,AutofillServerCommunication,SyncUSSBookmarks --flag-switches-begin --flag-switches-end
Executable Path C:\Program Files (x86)\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? not tested
  • Can you reproduce this issue with the dev channel? not tested
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@sebutek
Copy link
Author

sebutek commented Oct 30, 2019

I saw it is already fixed in #6573

@sebutek sebutek closed this as completed Oct 30, 2019
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants