white text is being used in certain area's making it hard to read when using light theme

[kjozwiak]

Description

As per @petemill, looks like the 'prominent' button text colour value is being used in more locations than just the 'prominent' button.

Also reported by @Brave-Matt via Slack 👍

Steps to Reproduce

Case #1

1. launch brave (0.73.12 CR: 78.0.3904.50 in this instance)
2. visit http://brianbondy.com and block JavaScript via Shields
3. click on the "lock" icon via URL and notice that the JS setting is blank/using white text

Case #2

1. launch brave (0.73.12 CR: 78.0.3904.50 in this instance)
2. login into https://stats.brave.com and save the password
3. once you've saved the password, logout and reload the website
4. click on the username to auto-fill and you'll notice that the username is using white text

** Case #3 **
From #6630

Actual result:

Expected result:

Text should be black and readable when using the light theme.

Reproduces how often:

100% reproducible when using the above STR.

Brave version (brave://version info)

Brave	0.73.12 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision	2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS	macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa @petemill @rebron @Brave-Matt

[LaurenWags]

Marking as QA/Blocked until new build is done. This will be available in 0.71.107 and above.

[GeetaSarvadnya]

The fix brave/brave-core#3801 is merged in 0.71.107 hence removed QA blocked label

[GeetaSarvadnya]

Verification passed on

Brave	0.71.107 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the STR from the description

  • Case 1 - JS settings white text box is removed now
    

  • Case 2 - saved username is displayed as expected
    
    

  • Case 3 - Text in find bar is visible when text is not selected.
    
    

Verification passed on

Brave	0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision	20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

  • Case 1 - JS settings
    

  • Case 2 - saved username is displayed as expected
    

  • Case 3 - Text in find bar is visible when text is not selected.
    

Verified passed with

Brave	0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision	20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified the test cases from the description

  • Case 1 - JS settings

• Case 2 - saved username is displayed as expected

• Case 3 - Text in find bar is visible when text is not selected.