Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift "Fix Unreadable Text Colors" #3801 to 0.72.x #3815

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Uplift "Fix Unreadable Text Colors" #3801 to 0.72.x #3815

merged 1 commit into from
Oct 31, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 29, 2019 •
edited by bsclifton
Loading

Fixes brave/brave-browser#6573

Fix unreadable text colors

Uplift #3801 to 0.72.x which already has brave-style buttons (#3569) which introduced the issue (brave/brave-browser#6573)

@petemill petemill requested a review from a team October 29, 2019 22:59
@petemill petemill requested a review from bridiver as a code owner October 29, 2019 22:59
@petemill petemill self-assigned this Oct 29, 2019
@petemill
Copy link
Member Author

Not sure if there's anything wrong here with CI? Pipeline steps look all green.

@yrliou
Copy link
Member

yrliou commented Oct 30, 2019

@petemill Looks like it timed out during init on Window, I can see that step is gray in the pipeline and stages after that are skipped.

@bsclifton
Copy link
Member

bsclifton commented Oct 31, 2019 •
edited
Loading

Just did a rebase (including the auto-generated brave-browser branch)... will keep an eye on CI here

@bsclifton bsclifton added this to the 0.72.x - Dev milestone Oct 31, 2019
@bsclifton bsclifton removed the request for review from bridiver October 31, 2019 04:40
kjozwiak
kjozwiak approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 5ea5ee2 into 0.72.x Oct 31, 2019
@bsclifton bsclifton deleted the fix-text-color-72x branch October 31, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@petemill @yrliou @bsclifton @kjozwiak