Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 3 ad notifications don't show the ad when clicked #6701

Closed
StephenTurley opened this issue Nov 1, 2019 · 3 comments
Closed

Gnome 3 ad notifications don't show the ad when clicked #6701

StephenTurley opened this issue Nov 1, 2019 · 3 comments

Comments

@StephenTurley
Copy link

Description

When clicking an ad notification in Gnome 3.34.1 the notification closes but the ad does not open.

Steps to Reproduce

  1. Click an ad notification
  2. Wait for browser to navigate to the ad

Actual result:

The notification closes but the ad is never opened.

Expected result:

I can see the ad

Reproduces how often:

Easily reproduced (happens everytmie)

Brave version (brave://version info)

Brave | 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)

Revision | edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS | Linux (PopOS 19.10)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the dev channel? unknown
  • Can you reproduce this issue with the nightly channel? unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@StephenTurley StephenTurley changed the title Gnome 3 ad notifications aren't clickable Gnome 3 ad notifications don't show the ad when clicked Nov 1, 2019
@StephenTurley
Copy link
Author

StephenTurley commented Nov 2, 2019

Here is the syslog that was generated:

Nov  2 09:34:03 stephen-desktop gnome-shell[3055]: JS ERROR: TypeError: this.notification is null#012_onClicked@resource:///org/gnome/shell/ui/calendar.js:748:9
Nov  2 09:34:04 stephen-desktop gnome-shell[3055]: message repeated 4 times: [ JS ERROR: TypeError: this.notification is null#012_onClicked@resource:///org/gnome/shell/ui/calendar.js:748:9]

@StephenTurley
Copy link
Author

This may be a gnome/pop_os bug. pop-os/pop#711

@StephenTurley
Copy link
Author

latest update to brave seems to have fixed the issue.

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Nov 11, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants