Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old icons are used in Disabled Rewards Settings #6756

Closed
btlechowski opened this issue Nov 4, 2019 · 5 comments
Closed

Old icons are used in Disabled Rewards Settings #6756

btlechowski opened this issue Nov 4, 2019 · 5 comments

Comments

@btlechowski
Copy link

Follow up from #6511. The fix was for new icons. Old icons looks too small with the fix per #6511 (comment). We need new icons.

Steps to Reproduce

  1. Clean profile
  2. Open brave://rewards
  3. Join the rewards

Actual result:

Icons are old and are too small
image
image

Expected result:

image
image

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

Not reproducible in 0.72.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? no
  • Can you reproduce this issue with the nightly channel? no

cc @ryanml @rebron @brave/legacy_qa

@ryanml
Copy link
Contributor

ryanml commented Nov 6, 2019

Closed via: brave/brave-core#3873

@ryanml ryanml closed this as completed Nov 6, 2019
@LaurenWags
Copy link
Member

Marking as QA/Blocked until build 0.71.113 or above.

@LaurenWags
Copy link
Member

on hold pending investigation by @ryanml as to why this isn't showing in 0.71.x

@LaurenWags
Copy link
Member

Moving milestone per discussion with @rebron @ryanml

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 14, 2019

Verification passed on

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
  • Verified on both clean and upgraded profile

Rewards ON:
image
image

Rewards toggled off
image
image
image

Verification passed on

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified STR from the description

image
image

Verified passed with

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description
    Rewards just turned ON (this displays briefly, or until page is refreshed):

Screen Shot 2019-11-14 at 10 30 28 AM

Screen Shot 2019-11-14 at 10 30 36 AM

Rewards turned OFF:
Screen Shot 2019-11-14 at 10 30 54 AM
Screen Shot 2019-11-14 at 10 31 03 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment