Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to brave://credits #6809

Closed
fmarier opened this issue Nov 7, 2019 · 4 comments · Fixed by brave/brave-core#3899
Closed

Add missing dependencies to brave://credits #6809

fmarier opened this issue Nov 7, 2019 · 4 comments · Fixed by brave/brave-core#3899

Comments

@fmarier
Copy link
Member

fmarier commented Nov 7, 2019

The chrome://credits/ page is generated by a script based on the licensing info included in specific directories.

@fmarier fmarier added the 1.0 label Nov 7, 2019
@fmarier fmarier added this to the 0.71.x - Release milestone Nov 7, 2019
@fmarier fmarier self-assigned this Nov 7, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2019

@fmarier autoplay-whitelist entry is not present under brave://credits in window 10 x64 brave version 0.71.114. As per the test plan brave/brave-core#3899, the entry should be available in brave://credits. Can you check it from your end and confirm, please?

@kjozwiak
Copy link
Member

kjozwiak commented Nov 11, 2019

Same result as @GeetaSarvadnya on macOS 10.15.1 x64. I'm not seeing autoplay-whitelist listed under brave://credits as per brave/brave-core#3899.

Also looks like Muli is still being displayed twice as per:

Screen Shot 2019-11-11 at 1 37 24 PM

Double checked https://github.com/brave/brave-core/commits/0.71.x and looks like 88c9110 landed in 0.71.114 CR: 78.0.3904.97 so we should be seeing the changes.

@kjozwiak
Copy link
Member

Created the following two issues as follow ups which will be addressed separately:

@kjozwiak
Copy link
Member

kjozwiak commented Nov 12, 2019

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Ensured that the following entries appeared under brave://credits:

  • Background images, Bluebird, boto, Brave Sync, Bulgarian adblock list, EasyList, Muli (listed twice), PROCHLO, Tor, TweetNaCl, ZXing

Also ensured that both show license/hide license and homepage worked for each of the above entries.

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Background images, Bluebird, boto, Brave Sync, Bulgarian adblock list, EasyList, Muli (listed twice), PROCHLO, Tor, TweetNaCl, ZXing

Also ensured that both show license/hide license and homepage worked for each of the above entries.

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Background images, Bluebird, boto, Brave Sync, Bulgarian adblock list, EasyList, Muli (listed twice), PROCHLO, Tor, TweetNaCl, ZXing

Also ensured that both show license/hide license and homepage worked for each of the above entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment