Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy xtb files of android_chrome_strings back to chromium #6998

Closed
yrliou opened this issue Nov 19, 2019 · 0 comments
Closed

Copy xtb files of android_chrome_strings back to chromium #6998

yrliou opened this issue Nov 19, 2019 · 0 comments
Assignees
@yrliou
Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Milestone
Android-Beta

Comments

@yrliou
Copy link
Member

yrliou commented Nov 19, 2019

After next push_l10n & pull_l10n, we should have our own xtb files for android_chrome_strings. We need to copy these xtb files back to chromium folder like https://github.com/brave/brave-browser/blob/master/lib/util.js#L165-L170 for the translations of our modified chromium strings.

cc @SergeyZhukovsky
@yrliou yrliou self-assigned this Nov 19, 2019
@yrliou yrliou added the QA/No label Nov 19, 2019
mkarolin added a commit that referenced this issue Nov 22, 2019
@mkarolin
Updated util.js to copy android XTB files.
54360bf 
Fixes #6998
mkarolin added a commit that referenced this issue Nov 22, 2019
@mkarolin
Updated util.js to copy android XTB files.
d95d7b6 
Fixes #6998
mkarolin added a commit that referenced this issue Nov 22, 2019
@mkarolin
Updated util.js to copy android XTB files.
ca9eb11 
Fixes #6998
mkarolin added a commit that referenced this issue Nov 23, 2019
@mkarolin
Updated util.js to copy android XTB files.
f1d9dfa 
Fixes #6998
mkarolin added a commit that referenced this issue Nov 25, 2019
@mkarolin
Updated util.js to copy android XTB files.
177af47 
Fixes #6998
mkarolin added a commit that referenced this issue Nov 26, 2019
@mkarolin
Updated util.js to copy android XTB files.
e98e566 
Fixes #6998
mkarolin added a commit that referenced this issue Nov 27, 2019
@mkarolin
Updated util.js to copy android XTB files.
5ba9d26 
Fixes #6998
@yrliou yrliou added this to the 1.3.x - Nightly milestone Dec 3, 2019
@srirambv srirambv modified the milestones: 1.3.x - Beta, Android-Beta Jan 7, 2020
@srirambv srirambv added the OS/Android Fixes related to Android browser functionality label Jan 10, 2020
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@mkarolin
Updated util.js to copy android XTB files.
2b125d4 
Fixes brave/brave-browser#6998
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@mkarolin
Updated util.js to copy android XTB files.
a80ee24 
Fixes brave/brave-browser#6998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
Android-Beta
Development

No branches or pull requests
2 participants
@yrliou @srirambv