Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if token expired before using it #7022

Closed
NejcZdovc opened this issue Nov 20, 2019 · 0 comments · Fixed by brave/brave-core#4025
Closed

Check if token expired before using it #7022

NejcZdovc opened this issue Nov 20, 2019 · 0 comments · Fixed by brave/brave-core#4025
Assignees
@NejcZdovc
Labels
feature/rewards QA/No release-notes/exclude
Milestone
1.3.x - Release

Comments

@NejcZdovc
Copy link
Contributor

We need to check if token expired before we use it in contribution. We also need to make sure that if token expires and we now don't have enough funds, proper error is shown to the user.
@NejcZdovc NejcZdovc self-assigned this Nov 20, 2019
This was referenced Nov 20, 2019
Closed
Merged
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 26, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 27, 2019
@NejcZdovc
Removes expired tokens when doing contribution
ff02ec9 
Resolves brave/brave-browser#7022
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 28, 2019
@NejcZdovc
Removes expired tokens when doing contribution
2561e04 
Resolves brave/brave-browser#7022
gdregalo pushed a commit to brave/brave-core that referenced this issue Jan 10, 2020
@NejcZdovc @gdregalo
Removes expired tokens when doing contribution
67081ab 
Resolves brave/brave-browser#7022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Token check brave/brave-core
2 participants
@NejcZdovc @LaurenWags