Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook videos don't play #705

Closed
srirambv opened this issue Aug 8, 2018 · 3 comments · Fixed by brave/brave-core#348
Closed

Facebook videos don't play #705

srirambv opened this issue Aug 8, 2018 · 3 comments · Fixed by brave/brave-core#348

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 8, 2018

Description

Browser doens't use fallback HTML5 video player when flash is blocked

Steps to Reproduce

  1. Install 0.53.1, ensure Flash is installed on the machine
  2. Visit this page in a new tab https://www.facebook.com/peopleareawesome/videos/vb.305140869535098/918408738208305/?type=2&theater
  3. Click play, shows error for flash player, doesn't use fallback HTML5 video player

Actual result:

Complains about flash player

Expected result:

Should use fallback HTML5 video player, similar to browser-laptop, instead of Flash

Reproduces how often:

100%

Brave version (about:brave info)

Brave	0.53.1 Chromium: 69.0.3497.12 (Official Build) dev (64-bit) 
Revision	e8e14b69c41a5a461c15fa5d1065ec28c49890ac-refs/branch-heads/3497@{#54}
OS	Windows
JavaScript	V8 6.9.427.5
Flash	30.0.0.134 C:\WINDOWS\system32\Macromed\Flash\pepflashplayer64_30_0_0_134.dll

Reproducible on current release:

No. browser-laptop uses HTML5 player even if flash is installed on the machine

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @diracdeltas @bridiver

@srirambv
Copy link
Contributor Author

Facebook videos fail to play as a result of this. Page just reloads but doesn't play video

@srirambv srirambv added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Aug 11, 2018
@bbondy bbondy changed the title Browser doens't use fallback HTML5 video player when flash is blocked Browser doesn't use fallback HTML5 video player when flash is blocked Aug 16, 2018
@LaurenWags
Copy link
Member

Video plays if shields are disabled.

@bbondy bbondy changed the title Browser doesn't use fallback HTML5 video player when flash is blocked Browser doesn't use fallback HTML5 video player when flash is blocked (Facebook) Aug 20, 2018
@bbondy bbondy changed the title Browser doesn't use fallback HTML5 video player when flash is blocked (Facebook) Facebook videos don't play Aug 21, 2018
@bbondy bbondy added the QA/Yes label Aug 21, 2018
bbondy added a commit to brave/brave-core that referenced this issue Aug 21, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 30, 2018

QA PASSED on windows.

Brave 0.54.3 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows

Verification Pass with

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants