-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up to #5722 - Wrong ads server url for ads/confirmations development environment #7132
Labels
dev-setup
feature/ads
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
tmancey
changed the title
Follow up to #5722 - Wrong ads server url for ads development environment
Follow up to #5722 - Wrong ads server url for ads/confirmations development environment
Nov 29, 2019
Merged
32 tasks
tmancey
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Nov 29, 2019
Verification passed on
Verified test plan from the description. The domain used is Verification passed on
Verification PASSED on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-setup
feature/ads
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Follow up to #5722. The url used for ads development environment is wrong.
Steps to Reproduce
--enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-development --rewards=development=true
Actual result:
ads urls points to
ads-serve.brave.software.com
serverads grant is shown by default
Was unable to claim the grant
ads catalog was not downloaded, because it points to dummy
https://ads-serve.brave.software.com/v1/catalog
Expected result:
ads urls points to
ads-serve.brave.software
serverrewards and ads work as expected
Note: expected ads url was provided by @tmancey
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @brave/legacy_qa @tmancey
The text was updated successfully, but these errors were encountered: