Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong ads server url for ads/confirmations development environment #4108

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 29, 2019

Fixes brave/brave-browser#7132

Submitter Checklist:

Test Plan:

See brave/brave-browser#7132

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 30, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Nov 30, 2019

Windows failed CI, rebuilding Windows

@tmancey tmancey removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 30, 2019
@tmancey tmancey merged commit 40c82ce into master Nov 30, 2019
@tmancey tmancey deleted the issues/7132 branch November 30, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up to #5722 - Wrong ads server url for ads/confirmations development environment
3 participants