Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ads has arrived! notification in BAT icon is shown after browser restart on clean installs #7133

Closed
btlechowski opened this issue Nov 27, 2019 · 4 comments · Fixed by brave/brave-core#4173

Comments

@btlechowski
Copy link

btlechowski commented Nov 27, 2019

Issue originally found by @GeetaSarvadnya (#6270 (comment))
@tmancey mentioned that this issue merits its own ticket

Steps to Reproduce

  1. Clean profile
  2. Enable rewards
  3. Turn off Ads switch
  4. Restart the browser

Actual result:

Brave Ads has arrived! notification in BAT icon is shown
image

Note: after dismissing the notification, it is no longer shown, even after browser restart.

Expected result:

Brave Ads has arrived! notification in BAT icon is NOT shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproduced on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS
Brave 1.1.11 Chromium: 78.0.3904.108 (Official Build) beta (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS
Brave 1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey @NejcZdovc @rebron

@btlechowski btlechowski changed the title Brave Ads has arrived! notification in BAT icon is shown after browser restart Brave Ads has arrived! notification in BAT icon is shown after browser restart on clean installs Nov 27, 2019
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 30, 2019
@NejcZdovc
Copy link
Contributor

+1 from my side

@NejcZdovc
Copy link
Contributor

I would say that this is P2 and something that we should fix asap as we receive already a lot of complains about notifications

cc @jsecretan @mandar-brave

@tmancey
Copy link
Contributor

tmancey commented Dec 7, 2019

@NejcZdovc edge case that would only happen once on a clean install if the user disables ads (after enabling rewards), the issue is now fixed and PR is awaiting review, thanks

@LaurenWags
Copy link
Member

LaurenWags commented Feb 7, 2020

Verified passed with

Brave 1.4.81 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)
  • Reproduced the issue on 1.3.113
  • Verified STR from description

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Reproduced the issue on 1.3.113
  • Verified STR from the description

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS
  • Reproduced the issue on 1.3.113
  • Verified STR from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment