Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads has arrived! notification in BAT icon is shown after browser restart on clean installs #4173

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 7, 2019

Fixes brave/brave-browser#7133

Submitter Checklist:

Test Plan:

See brave/brave-browser#7133

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey requested a review from masparrow December 9, 2019 10:40
@tmancey
Copy link
Collaborator Author

tmancey commented Dec 9, 2019

CI failed for unrelated reasons due to network audit

@tmancey
Copy link
Collaborator Author

tmancey commented Dec 10, 2019

Unrelated CI failure

@tmancey tmancey merged commit 2d477c5 into master Dec 10, 2019
@tmancey tmancey deleted the issues/7133 branch December 10, 2019 17:38
@tmancey tmancey added this to the 1.4.x - Nightly milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Ads has arrived! notification in BAT icon is shown after browser restart on clean installs
3 participants