Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads has arrived! notification in BAT icon is shown after browser restart on clean installs #4173

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fixes Brave Ads has arrived! notification in BAT icon is shown after browser restart on clean installs #4173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/brave_ads/browser/ads_service_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,7 +1807,13 @@ void AdsServiceImpl::OnPrefsChanged(
if (pref == prefs::kEnabled ||
pref == brave_rewards::prefs::kBraveRewardsEnabled) {
if (IsEnabled()) {
RemoveOnboarding();
#if !defined(OS_ANDROID)
if (first_run::IsChromeFirstRun()) {
SetBooleanPref(prefs::kShouldShowOnboarding, false);
} else {
RemoveOnboarding();
}
#endif
masparrow marked this conversation as resolved.
Show resolved Hide resolved

MaybeStart(false);
} else {
Expand Down