Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Suggestion: Restyle and implement inherited "tab groups" feature #7142

Open
Brave-Matt opened this issue Nov 28, 2019 · 17 comments
Open
Labels
design A design change, especially one which needs input from the design team feature/settings feature/tabs-bar feature/user-interface All UI related feature-request OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion

Comments

@Brave-Matt
Copy link

Description

It seems as though we've inherited Chrome's experimental "tab groups" feature and that it works in Brave as well without issue (seemingly). The feature still sits be hind a flag (#tab-groups) right now and I think it would be advantageous to hijack this feature and make it our own.

image

Functionality

The way the feature is currently implemented:

Right-clicking on a tab gives you options to Add, Add to existing or Remove a tab to/from a group.

groups

You can also drag tabs into (or out of) pre-existing groups.

tabdrag

If you Ctrl/Cmd + Click a link on a tab already grouped, the link will open and be automatically added to that same tab group.

tabcmdclick

Clicking the tab group color gives you options for customizing that groups color and giving each group a name/title.

image

Optionally/additionally, we may want to consider re-implementing the tab "pages" feature in conjunction with this, the way we did in Muon. I'm personally a fan of Cliftons "slick animation" example.

Miscellaneous Information:

Implementing this would make many users happy -- as it has been requested several times and in many different ways. These are just the ones I've pulled from Community in my initial search:

@srirambv
Copy link
Contributor

Finally, my suggestion from browser-laptop is implemented upstream. I'd give a +1 for tab colours so helpful when you have loads of tabs opened

@srirambv srirambv added the feature/user-interface All UI related label Nov 28, 2019
@rebron rebron added the design A design change, especially one which needs input from the design team label Jan 24, 2020
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 24, 2020
@bsclifton
Copy link
Member

bsclifton commented Apr 28, 2020

+1 from @jaredready via #9419

The latest release of Chrome and Chromium supports tab groups. Is this something that Brave is planning on supporting?

https://gizmodo[dot]com/tab-groups-is-chromes-best-new-feature-in-years-and-he-1842944249

@bsclifton
Copy link
Member

@PierreMardon
Copy link

Quick testimony : I almost hesitate to switch back to Chrome to benefit from this feature that I think would bring relief to any many-tabs-worker on a daily basis (don't know if I'm the only one that eager to have it available).

@Brave-Matt
Copy link
Author

@srirambv srirambv changed the title Suggestion: Restyle and implement inherited "tab groups" feature [Desktop] Suggestion: Restyle and implement inherited "tab groups" feature Sep 16, 2020
@jtbrown3
Copy link

The new 'Tab Groups' feature works really great in the Google Chrome browser - and really falls flat in Brave. Really hoping this feature will be properly implemented in Brave soon!

@Sojiro84
Copy link

Sojiro84 commented Jan 9, 2021

After trying out the Chromium's tab group feature with the sexy circular design and proper spacing vs Brave's square design with improper spacing (especially where the name of the tab-group color collides with the tab itself), I really prefer Chromium's version.

I hope you guys will fix the spacing. Right now it's visually unpleasant and since I use tab groups a lot, I am back to using Chromium until this is fixed.

@timelytree
Copy link

Tab groups have proven to be a very powerful and useful feature. Although functionally, they work well in Brave - visually as mentioned above, they're quite unpleasant and I do find myself missing the zen beauty of Chrome's UI implementation for them.


Actually this seems like it would be a pretty easy fix if we ever get something like a custom.css file as mentioned in brave/browser-laptop#1122 (moved to #774).

Customization similar to Atom; a simple doc you can edit


Adding some screenshots for reference:

Brave:
Screen Shot 2021-02-22 at 3 48 54 AM

Chrome:
Screen Shot 2021-02-22 at 3 49 42 AM

@urbenlegend
Copy link

I agree with @timelytree. The functionality works, but the square group name background and the extra line of pixels underneath each tab make it an eyesore.

@vedantb2
Copy link

I also agree with @timelytree. Is there any ETA on when this will be added to Brave?

@urbenlegend
Copy link

Any progress on this? Seems like it'd be a simple fix and would go a long way to making this feature actually usable in Brave.

@tunix
Copy link

tunix commented Nov 16, 2021

I look forward for a fix to this issue. It looks really ugly in Brave 😞

@CumpsD
Copy link

CumpsD commented Dec 7, 2021

If the text is a little long, like Financial, you hit the borders and the left/right padding is different from top/bottom, making it very ugly :(

@sudokai
Copy link

sudokai commented Apr 30, 2022

I'm a heavy tab groups user and, as petty as it sounds, I currently don't use Brave as my main browser because of this 😂

@jdsimcoe
Copy link

I'm with you, the fact that this hasn't been updated in years is keeping from using Brave as my primary browser.

@sangwoo108
Copy link

cc @aguscruiz and @zenparsing who recently updated tab style.

@aguscruiz
Copy link

We have a new style for groups that's coming with the new tab shape design that addresses this 🌈

If anyone wants to take it for a spin before it's official, the flag is #brave-horizontal-tabs-update

image

@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/settings feature/tabs-bar feature/user-interface All UI related feature-request OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion
Projects
Status: P5 backlog
Development

No branches or pull requests