Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad notifications no longer have a View button #7211

Closed
LaurenWags opened this issue Dec 4, 2019 · 6 comments
Closed

ad notifications no longer have a View button #7211

LaurenWags opened this issue Dec 4, 2019 · 6 comments

Comments

@LaurenWags
Copy link
Member

Description

On C79 versions the ad notifications no longer have a View button, just one large Close button.

For reference, I'm using High Sierra on macOS.

Steps to Reproduce

  1. Enable Rewards
  2. Browse until an ad is served.

Actual result:

Screen Shot 2019-12-04 at 4 21 00 PM

Expected result:

Screen Shot 2019-12-04 at 4 26 31 PM

Reproduces how often:

easily

Brave version (brave://version info)

1.1.18

Version/Channel Information:

  • Can you reproduce this issue with the current release? not on 1.0.1
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @bsclifton @mkarolin @rebron @brave/legacy_qa

@GeetaSarvadnya
Copy link

@LaurenWags Could be specific to macOS and Linux (not sure about Linux) - from the beginning, there is no View option in ads notification in Windows OS.

@LaurenWags
Copy link
Member Author

Adding 1.1.x milestone as this is likely a C79 regression we may want resolved before releasing.

@LaurenWags LaurenWags added this to the 1.1.x - Release milestone Dec 5, 2019
@lukemulks
Copy link

This actually improves consistency across desktop operating systems.

Linux (Fedora/Gnome): No view button.
Win10: No view button.

@bsclifton
Copy link
Member

Closing as wontfix after sharing with team and getting verbal approval from @jsecretan

@jsecretan
Copy link

Confirming the above

@btlechowski
Copy link

btlechowski commented Dec 6, 2019

Not reproducible on Linux. Adding OS/macOS label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants