Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens fail to retry due to empty nonce #7222

Closed
tmancey opened this issue Dec 5, 2019 · 9 comments · Fixed by brave/brave-core#4146
Closed

Tokens fail to retry due to empty nonce #7222

tmancey opened this issue Dec 5, 2019 · 9 comments · Fixed by brave/brave-core#4146

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 5, 2019

Description

Tokens fail to retry due to empty nonce

Steps to Reproduce

  1. View an ad

Actual result:

The console log shows tokens have been exceeded
Response: {"error":"Number of allowed tokens exceeded","statusCode":429}

Expected result:

The console log should show that tokens were successfully created (where 50 may vary)
Added 50 unblinded tokens, you now have 50 unblinded tokens

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Caused by brave/brave-core#4106

@btlechowski
Copy link

QA/Blocked on #7666

@LaurenWags
Copy link
Member

LaurenWags commented Jan 15, 2020

Verified passed with

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description
[27506:775:0115/113336.485560:INFO:refill_tokens.cc(50)] Refill
[27506:775:0115/113336.485573:INFO:refill_tokens.cc(75)] RequestSignedTokens
[27506:775:0115/113336.485584:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
[27507:775:0115/113336.489917:INFO:client.cc(574)] Successfully saved client state

Verification passed on

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS
  • Verified STR from description
[8773:8773:0116/021110.494479:INFO:refill_tokens.cc(50)] Refill
[8773:8773:0116/021110.494488:INFO:refill_tokens.cc(75)] RequestSignedTokens
[8773:8773:0116/021110.494494:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 48 unblinded tokens which is above the minimum threshold of 20

Verification passed on

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description
[18912:19852:0117/200125.928:INFO:refill_tokens.cc(50)] Refill
[18912:19852:0117/200125.928:INFO:refill_tokens.cc(75)] RequestSignedTokens
[18912:19852:0117/200125.928:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
[13240:12520:0117/200125.937:INFO:client.cc(574)] Successfully saved client state

@MeowMeowVenom
Copy link

If this thread is still active then i have the same issue

@MeowMeowVenom
Copy link

Also what is the meaning of wallet data is empty

@tmancey
Copy link
Contributor Author

tmancey commented Aug 18, 2020

@parasudilip Which version of the browser are you using please? And are you seeing failed to refill tokens? (Please DO NOT paste or share your logs)

@MeowMeowVenom
Copy link

Version 1.14.46 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit). This is from About Brave page. I am sorry for not posting the clear info the first time. The below lines are something which matches something about refill tokens.

Number of allowed tokens exceeded , statusCode : 429

Failed to refill unblinded tokens

Failed to request signed tokens

@tmancey
Copy link
Contributor Author

tmancey commented Aug 18, 2020

@parasudilip Do you have multiple browsers using the same wallet, and if so how many please. If you could email me directly with this information that would be great.

@MeowMeowVenom
Copy link

I have mailed to the mail in your profile.. Do check it

@tmancey
Copy link
Contributor Author

tmancey commented Aug 18, 2020

@parasudilip Running multiple instances with the same wallet id is not recommended at this time. I would recommend Joining Rewards for each instance until this is supported. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants