Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens fail to retry due to empty nonce #4147

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Tokens fail to retry due to empty nonce #4147

merged 1 commit into from
Dec 6, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 5, 2019

Fixes brave/brave-browser#7222
Uplift of: #4146

@tmancey tmancey added this to the 1.3.x - Dev milestone Dec 5, 2019
@tmancey tmancey requested a review from a team December 5, 2019 18:02
@tmancey tmancey self-assigned this Dec 5, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Dec 6, 2019

macOS failed CI, restarting macOS

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux and removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Dec 6, 2019
kjozwiak
kjozwiak approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 497230a into 1.3.x Dec 6, 2019
@kjozwiak kjozwiak deleted the issues/7222-1.3.x branch December 6, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak