Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken formatting of Monthly Contributions in brave://rewards for some locales #7296

Closed
btlechowski opened this issue Dec 10, 2019 · 2 comments · Fixed by brave/brave-core#4211
Closed

Broken formatting of Monthly Contributions in brave://rewards for some locales #7296

btlechowski opened this issue Dec 10, 2019 · 2 comments · Fixed by brave/brave-core#4211
Assignees
@NejcZdovc
Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.4.x - Release

Comments

@btlechowski
Copy link

The formatting of Monthly Contributions in brave://rewards in broken for Polish locale

Steps to Reproduce

  1. Clean profile
  2. Open Brave in Polish locale
  3. Enable Rewards
  4. Open brave://rewards

Actual result:

Broken formatting of Monthly Contributions. It looks squeezed.
image

Expected result:

image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS Ubuntu 18.04 LTS
Brave 1.2.20 Chromium: 79.0.3945.56 (Official Build) beta (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

cc @NejcZdovc @bradleyrichter @karenkliu @rebron @brave/legacy_qa
@btlechowski btlechowski added design A design change, especially one which needs input from the design team feature/rewards QA/Yes QA/Test-Plan-Specified labels Dec 10, 2019
@NejcZdovc
Copy link
Contributor

this can be also reproduced if you change description of the box to one word

image

@NejcZdovc NejcZdovc self-assigned this Dec 11, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 11, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 11, 2019
@NejcZdovc
Adds width to box card
f490c48 
Resolves brave/brave-browser#7296
@NejcZdovc NejcZdovc mentioned this issue Dec 11, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc added bug and removed design A design change, especially one which needs input from the design team labels Dec 11, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Feb 7, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.4.81 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-02-07 at 5 47 17 PM

  • Verified the STR from description

Zrzut ekranu 2020-02-7 o 5 51 31 PM

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

image

  • Verified the STR from the description

image

@kjozwiak kjozwiak mentioned this issue Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Adds width to box card brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya