Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crashes when loading a site via toptile in new tab #739

Closed
srirambv opened this issue Aug 11, 2018 · 1 comment · Fixed by brave/brave-core#378
Closed

Browser crashes when loading a site via toptile in new tab #739

srirambv opened this issue Aug 11, 2018 · 1 comment · Fixed by brave/brave-core#378
Labels
crash intermittent-issue QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Browser crashes when loading a site via toptile in new tab

Steps to Reproduce

  1. Visit a few sites so that top tiles are filled with different site links
  2. Close all tabs and keep new tab as single active tab and restart browser
  3. Click on one of the top tiles from history, browser crashes
  4. Repeat steps above, if you are lucky you will see crash again

Actual result:

Browser crashes when loading a site via top tile in new tab.

Expected result:

Should not crash

Reproduces how often:

Intermittent issue no extra steps required apart from whats mentioned above

Brave version (about:brave info)

0.53.2

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added this to the Backlog milestone Aug 11, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds 0.55.x Aug 31, 2018
@bbondy bbondy added QA/Yes and removed needs-investigation A bug not 100% confirmed/fixed labels Aug 31, 2018
@bbondy bbondy mentioned this issue Aug 31, 2018
Merged
11 tasks
bbondy added a commit to brave/brave-core that referenced this issue Aug 31, 2018
@bbondy
Use a single sequenced task runner for HTTPSEverywehre
0532a57 
Otherwise we're creating lots of different threads and accessing things for the DB on different possibly overlapping threads

I think this also fixes:
brave/brave-browser#707
brave/brave-browser#708
brave/brave-browser#739
brave/brave-browser#797
brave/brave-browser#761
brave/brave-browser#762
brave/brave-browser#796
brave/brave-browser#797
brave/brave-browser#798
brave/brave-browser#861
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2018 •
edited by kjozwiak
Loading

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification Pass with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash intermittent-issue QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use a single sequenced task runner for HTTPSEverywehre && level_db init fix brave/brave-core
4 participants
@bbondy @srirambv @LaurenWags @GeetaSarvadnya