Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Learn more" under "Congratulations" screen pointing to MM Zenhub #7444

Closed
kjozwiak opened this issue Dec 18, 2019 · 3 comments · Fixed by brave/ethereum-remote-client#101
Closed

Comments

@kjozwiak
Copy link
Member

Description

Looks like this was originally supposed to be addressed via #4772 but it was closed without it ever being resolved. I looked around and couldn't find an issue under :

is:open label:feature/crypto-wallets https://metamask.zendesk.com/hc/en-us/articles/360015489591-Basic-Safety-Tips

Steps to Reproduce

  1. launch brave and open brave://wallet
  2. click on Restore and restore a wallet (MM or CW)
  3. click on Learn more. and you'll be taken to https://metamask.zendesk.com/hc/en-us/articles/360015489591-Basic-Safety-Tips

Actual result:

Shouldn't be using https://metamask.zendesk.com/hc/en-us/articles/360015489591-Basic-Safety-Tips

Expected result:

Screen Shot 2019-12-18 at 12 44 58 AM

Should open a help page that's located on https://support.brave.com and not https://metamask.zendesk.com.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 1.1.22 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.15.1 (Build 19B88)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @ryanml @srirambv

@srirambv
Copy link
Contributor

This is a regression of #6100

@rebron
Copy link
Collaborator

rebron commented Dec 18, 2019

cc: @Brave-Matt for url for article.

@rebron rebron added the support addition/edits to articles on support website label Dec 18, 2019
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 20, 2019
@ryanml ryanml self-assigned this Jan 6, 2020
@srirambv
Copy link
Contributor

srirambv commented Jan 9, 2020

Verification passed on

Brave 1.4.55 Chromium: 79.0.3945.117 (Official Build) dev (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Linux
Component 0.1.35

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1809 (Build 17134.523)
Component 0.1.35

Verification passed on

Brave 1.5.18 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants