Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add balance check #916

Closed
NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#413
Closed

Add balance check #916

NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#413
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

When you are on rewards page we need to check for balance every minute
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 2, 2018
@NejcZdovc
Copy link
Contributor Author

I think this should be done in JS with setInterval and calling getBalance into c++

@NejcZdovc NejcZdovc self-assigned this Sep 5, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 6, 2018
@NejcZdovc
Adds balance check
2c8d816 
Fixes brave/brave-browser#916
@NejcZdovc NejcZdovc mentioned this issue Sep 6, 2018
Merged
11 tasks
@bbondy bbondy added the QA/Yes label Sep 10, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2018 •
edited by GeetaSarvadnya
Loading

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified adding funds to wallet showed up within 1 minute of transfer

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Verified adding funds to wallet showed up within 1 minute of transfer

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows
  • Verified adding funds to wallet showed up within 1 minute of transfer

This was referenced Dec 13, 2019
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Dec 13, 2019
Closed
This was referenced Dec 13, 2019
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Dec 13, 2019
Closed
80 tasks
@qingxiang-jia qingxiang-jia mentioned this issue Dec 13, 2019
Closed
@Allespro Allespro mentioned this issue Dec 14, 2019
Closed
@nate2014jatc nate2014jatc mentioned this issue Dec 15, 2019
Closed
@onmyouji onmyouji mentioned this issue Dec 15, 2019
Closed
@thanuj10 thanuj10 mentioned this issue Dec 16, 2019
Closed
@xoroz xoroz mentioned this issue Dec 16, 2019
Closed
This was referenced Dec 16, 2019
Closed
Closed
This was referenced Dec 16, 2019
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Dec 16, 2019
Closed
23 tasks
@LaurenWags LaurenWags mentioned this issue Dec 16, 2019
Closed
23 tasks
@btlechowski btlechowski mentioned this issue Dec 16, 2019
Closed
23 tasks
@srirambv srirambv mentioned this issue Dec 16, 2019
Closed
@bsclifton bsclifton mentioned this issue Dec 17, 2019
Closed
@Strategerizer Strategerizer mentioned this issue Dec 17, 2019
Open
This was referenced Dec 17, 2019
Open
Closed
@JamesABaker JamesABaker mentioned this issue Dec 17, 2019
Closed
This was referenced Dec 17, 2019
Closed
Closed
This was referenced Dec 18, 2019
Closed
Closed
@atharvan atharvan mentioned this issue Dec 18, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Dec 18, 2019
Closed
This was referenced Dec 18, 2019
Closed
Closed
This was referenced Dec 18, 2019
Closed
Closed
This was referenced Dec 18, 2019
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Dec 18, 2019
Closed
This was referenced Dec 19, 2019
Closed
Closed
Closed
@Arcbot-ArcusBD Arcbot-ArcusBD mentioned this issue Jan 6, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds balance check brave/brave-core
5 participants
@bbondy @NejcZdovc @srirambv @LaurenWags @GeetaSarvadnya